Use tx.from fallback to account in boopFromTransaction in iframe sendBoop func #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
AryanGodara
changed the title
AryanGodara
changed the title
Deploying happychain with
|
| Latest commit: |
44815eb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://465dd754.happychain.pages.dev |
| Branch Preview URL: | https://aryan-txfrom-in-sendboop-opt.happychain.pages.dev |
AryanGodara
changed the base branch from
aryan/leaderboard-auth
to
graphite-base/790
AryanGodara
force-pushed
the
graphite-base/790
branch
from
d7b5c98 to
5d0d9d1
Compare
AryanGodara
force-pushed
the
aryan/txfrom-in-sendBoop-optional
branch
from
932198e to
22a646c
Compare
AryanGodara
force-pushed
the
aryan/txfrom-in-sendBoop-optional
branch
2 times, most recently
from
d53296d to
0c759eb
Compare
norswap
reviewed
May 22, 2025
| dest: tx.to, | ||
| payer: zeroAddress, // happyPaymaster, // TODO need to fund paymaster | ||
| value: tx.value ? BigInt(tx.value) : 0n, | ||
| value: tx.value !== undefined ? (parseBigInt(tx.value) ?? 0n) : 0n, |
Collaborator
There was a problem hiding this comment.
Because of how parseBigInt (one of our utility function) works, all of these can be parseBigInt(thing) ?? fallback — I actually completely coincidentally made the change in the PR I'm working on, so this can stay like this.
norswap
approved these changes
May 22, 2025
norswap
force-pushed
the
aryan/txfrom-in-sendBoop-optional
branch
from
77b0a49 to
d1fd9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: HAPPY-552
Updated the
boopFromTransactionfunction to use the provided account as a fallback whentx.fromis not available. This ensures the function can handle transactions where the sender information might be missing.I went through the surrounding code flow (from request handlers to utils inside
iframe/src/requests). But I couldn't find any other thing which had to be tweaked, as there was no description for the linear issue, only title 😅Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments (e.g. local,
testnet, mainnet, standalone wallet, ...).
C3. I have manually tested my changes & connected features.
C4. I have performed a thorough self-review of my code after submitting the PR,
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
Public APIS and meaningful (non-local) internal APIs are properly documented in code comments.
in a Markdown document.
make changesetforbreaking and meaningful changes in packages (not required for cleanups & refactors).