New and improved make build system and other cleanups#13
Merged
someone2639 merged 18 commits intoHackerN64:mainfrom Aug 24, 2025
Merged
New and improved make build system and other cleanups#13someone2639 merged 18 commits intoHackerN64:mainfrom
someone2639 merged 18 commits intoHackerN64:mainfrom
Conversation
… versions under the new build system This is a holdover from the decomp, as it must support older libultra versions which used these functions; as we're basing this project off of the final 2.0L, they gotta go
Will be removed completely by HackerN64#12 soon enough anyway, but this will break CI if I don't remove this
Based off my personal "template" featuring makedepend and support for automatically building and installing all 3 library versions, along with colors Still needs cleanup to make sure I've brought over everything from the previous makefile
Collaborator
Author
|
This PR is still WIP (I'd like to make sure everything's clean and organized) |
CrashOveride95
requested review from
Thar0,
gheskett and
someone2639
as code owners
someone2639
reviewed
Aug 23, 2025
.github/workflows/ci_gcc.yml
Outdated
| matrix: | ||
| version: [L] # [H, I, I_patch, J, K, L] | ||
| suffix: [~, _d, _rom] | ||
| version: [[libultra, libultra_d, libultra_rom]] |
There was a problem hiding this comment.
Remind me what the difference is between _rom and no prefix again (I remember there being no use case for the latter)
Collaborator
Author
There was a problem hiding this comment.
libultra_rom and libultra are both compiled with optimizations -Os and have NDEBUG declared. However, libultra_rom also declares _FINALROM, and there are a great many changes made with this flag, including disabling most remaining debugging code (such as assert), printfs, etc
libultra is intended as a middle ground between a completely final retail build and a development build
Thar0
reviewed
Aug 24, 2025
Thar0
approved these changes
Aug 24, 2025
someone2639
approved these changes
Aug 24, 2025
someone2639
left a comment
someone2639
left a comment
There was a problem hiding this comment.
run python format.py then i can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to make the build system better with fancy colors, makedepend, and new build targets for building all 3 versions + installing build artifacts
Additionally, I would like to remove remnants of the decomp process that the project no longer needs