Rename all TODOs to DECOMP_DO and HACKERSM64_DO#927
Open
gheskett wants to merge 1 commit intoHackerN64:develop/2.4.0from
Open
Rename all TODOs to DECOMP_DO and HACKERSM64_DO#927gheskett wants to merge 1 commit intoHackerN64:develop/2.4.0from
gheskett wants to merge 1 commit intoHackerN64:develop/2.4.0from
Conversation
The TODO keyword should really be reserved for actual ROM hackers, as most of them probably couldn't care less about any HackerSM64 or decomp tech debt. Searchability for the TODO keyword, as well as HACKERSM64_DO and DECOMP_DO should also be a lot easier now, with fewer irrelevant results.
Collaborator
|
wait you guys unironically search for the TODO comments that you left? i thought it was a bit |
Collaborator
Author
|
Believe it or not, yes (especially in hacks) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TODO keyword should really be reserved for actual ROM hackers, as most of them probably couldn't care less about any HackerSM64 or decomp tech debt. Searchability for the TODO keyword, as well as HACKERSM64_DO and DECOMP_DO should also be a lot easier now, with fewer irrelevant results.