Open
Conversation
gheskett
reviewed
Nov 30, 2025
Collaborator
gheskett
left a comment
There was a problem hiding this comment.
I would update basic_update() to not take an argument. Looks fine to me otherwise, assuming everything compiles as expected.
Collaborator
Author
It already does not This was the main reason why compilation failed. Apparently C17 was fine with it. |
gheskett
approved these changes
Nov 30, 2025
Collaborator
gheskett
left a comment
There was a problem hiding this comment.
Me when I accidentally cross compare the wrong repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #911 for 3.0 branch. Still requires merge in from 2.4.x but intentionally omitted to avoid merge conflicts.
print_text(20, 20, "TEST")pattern.