Open
Conversation
Yanis002
added
bug
Yanis002
removed
the
waiting for author
Yanis002
added
the
priority
Yanis002
removed
the
priority
Collaborator
Author
|
this got issues again and idk why, and I don't feel like looking at it right now so it'll stay in limbo for a bit lol |
Yanis002
added
the
priority
Collaborator
Author
|
I fixed the strange build issues but it still doesn't boot idk why, I'll try to debug this soon |
Collaborator
Author
|
I have no idea why CI is failing, it's not even related to those changes |
Yanis002
commented
Dec 11, 2025
Comment on lines
-530
to
-533
| $(BUILD_DIR)/src/overlays/actors/ovl_Item_Shield/%.o: OPTFLAGS := -O2 | ||
| $(BUILD_DIR)/src/overlays/actors/ovl_En_Part/%.o: OPTFLAGS := -O2 | ||
| $(BUILD_DIR)/src/overlays/actors/ovl_Item_B_Heart/%.o: OPTFLAGS := -O0 | ||
| $(BUILD_DIR)/src/overlays/actors/ovl_Bg_Mori_Hineri/%.o: OPTFLAGS := -O0 |
Collaborator
Author
There was a problem hiding this comment.
TODO: test again if this is necessary
|
|
||
| # for ISOs we need to do things manually since we want to remove | ||
| # the useless files that increase the size of the file by a lot | ||
| iso: |
Collaborator
Author
There was a problem hiding this comment.
TODO: test again gamecube builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds my fixes to make Wii VC and GameCube VC behave properly, the HackerOoT-side should be ready but I still need to complete the basic F3DEX3 support in the emulator, also I need to do a self-review before merging this (and it needs testing)
Also there's audio issues hence the waiting for author label because idk, I'm clueless on this it doesn't do that on vanilla decomp so I'm lost on this one, idk how to debug that (actually I'm building with- update: I fixed it!mips-n64-gcc, it could be the issue)and I swear I'm gonna review the other PRs lol, just haven't found the time for that yet