feat: Support additional arguments, required for ActiveRecord 7.1#220
Open
tomdev wants to merge 2 commits intoHacker0x01:masterfrom
Open
feat: Support additional arguments, required for ActiveRecord 7.1#220tomdev wants to merge 2 commits intoHacker0x01:masterfrom
tomdev wants to merge 2 commits intoHacker0x01:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
arel_toolkitv0.6.0 I'm running into the following error when used in a Rails 7.1 application (which is using active_record 7.1.3.3):In
active_record7.1 the exec_no_cache and exec_cache methods require the keywords:allow_retryand:materialize_transactions.arel_toolkitwas not passing these arguments.This PR passes any additional arguments passed in to the
supercall to resolve this issue.