fix/abm-sd-sync-stuck-geolocation #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for bluetooth permission screen in the two flows
…sking for location permission screen in the flow
xameYeoh
commented
Jun 30, 2025
Comment on lines
56
to
+57
| if sessionContext.isMobileSession { | ||
| isMobileLinkActive = true | ||
| } else if bluetoothHandler.isBluetoothDenied() { | ||
| isTurnBluetoothOnLinkActive = true | ||
| isProceedToSelectDeviceTypeLinkActive = true |
Collaborator
Author
There was a problem hiding this comment.
This is here essentially because the UI is structured in the way that when you go to create a mobile session:
- You are asked for location permission
- You choose the device type (Mic or AB)
- You are asked for bluetooth permission if you've chosen AB
mpanuszewska
approved these changes
Jun 30, 2025
| } | ||
|
|
||
| var isSDSyncProcess: Bool { | ||
| return if case .sdSync = process { true } else { false } |
Collaborator
There was a problem hiding this comment.
wouldn't return case .sdSync = process work?
Collaborator
Author
There was a problem hiding this comment.
It says "case label can only appear inside a switch statement"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue found in build 1.22.0 with Bluetooth screen not showing during Sync and Clear SD flows;
It also addresses the issue with Location screen not showing during Create a Fixed session flow, which had been present in the app in the earlier versions too