Remove AWS mentions in glidein_requests.py #521
+98
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This correctly reflects the changes I made and should do what I wanted it to do. I was a bit surprised that the toml file never included the AWS modules as a dependency before. Obviously it does not need to do so anymore. I leave the formal approval of the module to the other developers. |
StevenCTimm
approved these changes
Jan 8, 2026
Contributor
StevenCTimm
left a comment
StevenCTimm
left a comment
There was a problem hiding this comment.
Approved--this PR will do what it needs to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the references to AWS in glidein_requests.py
I rebased Steve's changes on the current master and made a commit as Steve.
This superseeds PR #520 which was based on outdated, conflicting code and should be closed w/o merge.
I also fixed the REUSE compliance, which was quick. Tests requiring the wheel package are failing. This should be checked separately.