-
Notifications
You must be signed in to change notification settings - Fork 95
Use entry animations on respawn platform #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jobrien97
wants to merge
22
commits into
pre-release
Choose a base branch
from
rebirth_entry
base: pre-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aesthetics
Animation, sound, or effect changes
discussion ongoing
Content has yet to be agreed upon
engine
For working on engine changes
semver:patch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thanks to @Armasher5872 for the original implementation.
This changes respawn to use the character's entry animation rather than their idle animation.
Characters will usually enter the screen midway through their entry animation, so that respawn platform actionability lines up with the character's "rest" position in their animation (to prevent janky transitions upon leaving the platform immediately).
As a consequence, you will now only be able to taunt on the respawn platform once actionable.
Some examples:
SysDVR-Client.PID.19240.2025-04-22.20-56-29.mp4
SysDVR-Client.PID.19240.2025-04-22.21-02-28.mp4
SysDVR-Client.PID.19240.2025-04-22.20-57-09.mp4
SysDVR-Client.PID.19240.2025-04-22.21-01-31.mp4
SysDVR-Client.PID.19240.2025-04-22.21-00-20.mp4
SysDVR-Client.PID.19240.2025-04-22.20-59-36.mp4
SysDVR-Client.PID.19240.2025-04-22.20-58-32.mp4
SysDVR-Client.PID.19240.2025-04-22.21-06-34.mp4
SysDVR-Client.PID.19240.2025-04-22.21-05-52.mp4
SysDVR-Client.PID.19240.2025-04-22.21-04-57.mp4
SysDVR-Client.PID.19240.2025-04-22.21-03-24.mp4