Add support for including driver and supplemental files in HLKX package

[zjmletang]

• Add upload_to_studio method for uploading files directly to Studio
• Update create_project_package to accept driver_path and supplemental_path
• Update createprojectpackage PowerShell function with driver/supplemental params
• Use HLK API PackageWriter.AddDriver() and AddSupplementalFiles() to include files

[gemini-code-assist]

Summary of Changes

Hello @zjmletang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the capability of HLKX package creation by enabling the direct inclusion of driver and supplemental files. It achieves this by extending an existing package creation method with new parameters and introducing a dedicated utility for uploading files to the Studio environment, streamlining the packaging process for hardware components.

Highlights

• HLKX Package Enhancement: The create_project_package method has been updated to support the inclusion of driver and supplemental files directly into the generated HLKX package.
• New File Upload Utility: A new upload_to_studio method has been introduced, providing functionality to upload local files or directories to the Studio machine.
• Parameter Expansion: The create_project_package method now accepts driver_path and supplemental_path parameters, allowing users to specify the files to be included.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies lib/rtoolsHCK.rb by extending the create_project_package method to accept driver_path and supplemental_path parameters, allowing these paths to be included when generating a project package. Additionally, a new upload_to_studio method is introduced to enable uploading files or directories to a studio machine using WinRM. No review comments were provided.

[YanVugenfirer]

Discussion only: @kostyanf14 do we want to sign the package as part of capabilities of rtoolshck?

[kostyanf14]

Discussion only: @kostyanf14 do we want to sign the package as part of capabilities of rtoolshck?

For production signing, this means that the EV certificate token should be attached to the machine with the HLK controller, but this is regularly wrong.

[kostyanf14]

What if we provide symbolPath=driver? In the case of RH, we pack symbols to HLKX package too.

[zjmletang]

@kostyanf14

Do you expect the symbols folder to contain a PDB directory? I set $symbolPath = $driver, but the PDB folder in the resulting HLKX package is still empty. I'm still investigating this issue

[kostyanf14]

I expect that HLKX will contain symbols. Maybe we should find all *pdb in $driver and move to $symbolPath.

[kostyanf14]

pathToDriver - The path to the driver files. All files in this directory and all subdirectories will be packaged.

pathToSymbols - The path to the symbol files for this driver. This parameter is optional.

Maybe pathToSymbols is the path to exactly ONE pdb file. I don't test, just reading docs. This is strange because what to do with GPU, or Socket where you have KMD and UMD

[zjmletang]

@kostyanf14 Thanks. I will test and verify it tomorrow and get back to you

[zjmletang]

@kostyanf14 I’ve verified that we can use a folder containing only PDB files as input, and it can include multiple pdb files. In other words, if we want to package PDB files, we just need to put them in the 'driver' directory. The script will automatically collect them into a clean folde. I've resubmitted the code

[kostyanf14]

@zjmletang Thanks for your effort!