Skip to content

Conversation

@zjmletang
Copy link
Contributor

This commit implements a workaround to bypass the driver signing issue encountered in HLK 2022.

For more details, see: #819

This commit implements a workaround to bypass the driver signing issue
encountered in HLK 2022.

For more details, see: HCK-CI#819


Signed-off-by: Zhang JianMing <zhangjianming.zjm@alibaba-inc.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @zjmletang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical fix to bypass a driver signing issue within the Microsoft Hardware Lab Kit (HLK) 2022 environment. By modifying the HLK 2022 kit configuration, a specific driver fix is now included, which resolves the problem of unsigned drivers preventing proper testing. This change ensures that HLK 2022 operations can continue smoothly without being blocked by this known signing challenge.

Highlights

  • HLK 2022 Workaround: Implemented a workaround to address the Microsoft HLK 2022 unsigned driver issue, allowing testing to proceed without encountering this specific signing problem.
  • Configuration Update: The HLK2022.json configuration file was updated to include NDIS_Driver_Fix in the extra_software list, which is the core of the implemented workaround.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively implements the workaround for the Microsoft HLK 2022 unsigned driver issue by adding "NDIS_Driver_Fix" to the extra_software list in the HLK2022.json configuration. This change directly addresses the problem as described in the pull request title and body.

@zjmletang
Copy link
Contributor Author

hi @kostyanf14 The NDIS_Driver_Fix has been merged, so I’ve submitted a separate patch to autohck to ensure the HLK2022 test passes. Please take a look when you have a moment (I’ve verified that it works).

@kostyanf14 kostyanf14 merged commit 2d61571 into HCK-CI:master Jan 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants