On branch notify-icon-fix #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: hyprshot Addressed the following issues: * Allow the user to leverage their system settings for the timeout in `notify-send`. Previously, the timeout was hardcoded to 5000 ms, which is quite long for an information message. * Fix the icon for the notifications. The information icon was not displayed when a screenshot was taken since the priority of the message was not given as an argument to `notify-send`. By adding the 'dialog-information' priority, the icon is displayed conditionally when the screenshot is taken and not saved to a file. When saved to a file, the screenshot is used as the icon. * Improved readability of the notifications title and body text. The name of the tool, Hyprshot, is now displayed in the title, and the body includes clarifying text indicating the screenshot was taken rather than the more generic verbiage about an image being saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: hyprshot
Addressed the following issues:
Allow the user to leverage their system settings for the timeout in
notify-send. Previously, the timeout was defaulting to 5000 ms, which is quite long for an information message. While it could be changed, it was not responsive to or respecting system settings.Fix the icon for the notifications. The information icon was not displayed when a screenshot was taken since the priority of the message was not given as an argument to
notify-send. By adding the 'dialog-information' priority, the icon is displayed conditionally when the screenshot is taken and not saved to a file. When saved to a file, the screenshot is used as the icon.Improved readability of the notifications title and body text. The name of the tool, Hyprshot, is now displayed in the title, and the body includes clarifying text indicating the screenshot was taken rather than the more generic verbiage about an image being saved.
After: Priority associated icon is present, and it's properly registering as an informational message.
Before: Priority inappropriately registering as normal rather that informational, and lacking the priority associated icon in absence of the image being saved to disk.