Add inventory sell command for multiple items #8
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!this.validateSell(player, price, auctionEconomy, sellableItems)) { | ||
| sellableItems.forEach(itemStack -> player.getInventory().addItem(itemStack)); | ||
| return; |
There was a problem hiding this comment.
When a sell-inventory confirmation fails validation (price too high/low, world banned, blacklist, etc.), the items are added back with player.getInventory().addItem(...) but the returned overflow map is ignored. If the player’s inventory is already full, the stacks taken out of the SellInventory are silently lost instead of being dropped, and the same pattern appears in the exception handler below. This is a regression from the single-item flow, which validates before removing items, and results in item loss whenever validation or creation rejects a batch sale while the player has no free slots.
Useful? React with 👍 / 👎.
Summary
/ah sellinventorycommand that opens an inventory for selling multiple items at onceTesting
Codex Task