Skip to content

Potential fix for code scanning alert no. 1: DOM text reinterpreted as HTML #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GrimbiXcode wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 1: DOM text reinterpreted as HTML #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2302,11 +2302,26 @@ class MTGScanner {
// Create notification element
const notification = document.createElement('div');
notification.className = `notification ${type}`;
notification.innerHTML = `
<div class="notification-icon">${icons[type] || icons.info}</div>
<div class="notification-content">${message}</div>
<button class="notification-close" aria-label="Close notification">✕</button>
`;

// Icon (HTML-safe, from known set)
const iconElem = document.createElement('div');
iconElem.className = 'notification-icon';
iconElem.innerHTML = icons[type] || icons.info;

// Message (potentially user input, MUST use textContent)
const messageElem = document.createElement('div');
messageElem.className = 'notification-content';
messageElem.textContent = message;

// Close button (static)
const closeBtn = document.createElement('button');
closeBtn.className = 'notification-close';
closeBtn.setAttribute('aria-label', 'Close notification');
closeBtn.textContent = '✕';

notification.appendChild(iconElem);
notification.appendChild(messageElem);
notification.appendChild(closeBtn);

// Add to container
this.notificationContainer.appendChild(notification);
Expand Down