Skip to content

Conversation

@RealWhimsy
Copy link

The removeEvent() function allows removal of events by their ID.

I used this in a project to allow the user to detect click events on entries in the timetable and remove them. The ID is needed to distinguish between entries with similar names.

The removeEvent() function allows removal of events by their ID
@stevenaanen
Copy link

Thanks for the PR, seems like a useful addition 👍. Your changes were however committed on the dist files instead of the source files, so you bypassed the build system (and it's tests and code style rules). Also, I was wondering how events get their ID in this approach?

Added a line that assigns an ID to a timetable - entry item on its
creation in addEvent()
@RealWhimsy
Copy link
Author

I forgot to add a line of code that actually assigned the IDs, the correct version is now committed.
IDs get assigned on creation of a new entry in the addEvent() function, then the ID variable gets incremented by 1.

Also I'm sorry for commiting on the wrong files, this is my first contribution to another repository on GitHub. If you could give me a pointer on what files to modify it would be greatly appreciated, since I can only find a dist folder but no src/source folder in my forked repository.

@stevenaanen
Copy link

There's an app folder (instead of src) which contains the source files. Gulp is used to compile the project and there is also a test suite in the test folder. Please have a look at those as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants