Develop

[GrammaTonic]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @GrammaTonic, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant change in how Prometheus metrics are collected and exposed for GitHub Actions runners, transitioning from a Go-based application to a more streamlined bash and netcat approach. This aims to reduce complexity and external dependencies. Concurrently, it incorporates a critical security fix for CVE-2025-64756, a command injection vulnerability in the glob package, ensuring the standard runner Docker image is updated to a secure version of the dependency.

Highlights

• Prometheus Metrics Implementation Switch: The strategy for implementing Prometheus metrics has shifted from a Go-based exporter to a lightweight solution using netcat and bash scripts, aiming for reduced complexity and dependencies.
• CVE-2025-64756 Fix: A high-severity command injection vulnerability in the glob package (CVE-2025-64756) has been addressed by updating the glob dependency to version 13.0.0 in the standard Dockerfile, aligning its security posture with other runner images.
• Documentation Updates: Relevant documentation files have been updated to reflect both the new Prometheus implementation approach and the details of the glob vulnerability fix, including new bash script examples.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/monitoring.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two main changes. First, it addresses a security vulnerability (CVE-2025-64756) in the glob npm package by patching it in the Docker images. The implementation for this fix is sound. Second, it pivots the Prometheus metrics implementation from a Go-based exporter to a more lightweight solution using bash and netcat, which is reflected across several documentation and planning files.

My review focuses on improving the documentation to ensure the examples and verification steps are accurate and robust. I've suggested updating a verification command in the CVE fix documentation to be more comprehensive, and I've pointed out an issue in the bash script example for the new metrics server.

Overall, the changes are positive, especially the security fix. A more descriptive pull request title and body would be helpful for future reference.

[gemini-code-assist]

The verification command is hardcoded to check only the node24 directory. However, the patching logic in the Dockerfile correctly iterates over all node* directories. To ensure the vulnerability is fixed in all embedded Node.js versions, the verification command should also loop through all available versions.

This makes the verification process more robust and aligned with the implementation.

Suggested change

	docker run --rm github-runner:latest \
	bash -c 'node -e "console.log(require(\"/actions-runner/externals/node24/lib/node_modules/npm/node_modules/glob/package.json\").version)"'
	docker run --rm github-runner:latest bash -c '
	for dir in /actions-runner/externals/node*/; do
	path="${dir}lib/node_modules/npm/node_modules/glob/package.json"
	if [ -f "$path" ]; then
	echo -n "${dir}: "
	node -p "require(\"$path\").version"
	fi
	done
	'

[gemini-code-assist]

The example for the metrics server script uses a command substitution RESPONSE=$(...) but the RESPONSE variable is never used. This is misleading and inefficient as it captures the client's request into a variable that is immediately discarded.

Additionally, it uses nc -q 1, which introduces an unnecessary 1-second delay after each request. The actual implementation (docker/metrics-server.sh) correctly uses -q 0 to exit immediately. The documentation should reflect the more efficient approach.

The command substitution should be removed and -q 0 should be used.

Suggested change

	RESPONSE=$(echo -e "HTTP/1.1 200 OK\r\nContent-Type: text/plain; version=0.0.4\r\n\r\n$(cat \"$METRICS_FILE\" 2>/dev/null || echo '# No metrics available')" | nc -l -p "$PORT" -q 1)
	echo -e "HTTP/1.1 200 OK\r\nContent-Type: text/plain; version=0.0.4\r\n\r\n$(cat \"$METRICS_FILE\" 2>/dev/null || echo '# No metrics available')" | nc -l -p "$PORT" -q 0