-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: promote develop to main (Dec 2025) #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
450a471
docs: enhance PR template with comprehensive squash merge workflow
GrammaTonic 3e9d894
chore: sync develop with main after squash merge
GrammaTonic bad8357
feat(prometheus): Phase 1 - Standard Runner Metrics Endpoint (#1066)
GrammaTonic b7161fd
chore(deps): chore(deps)(deps): bump aquasecurity/trivy-action from 0β¦
dependabot[bot] 492ce7b
chore(deps): chore(deps)(deps): bump actions/upload-artifact from 4 to 5
dependabot[bot] 6580102
chore(deps): chore(deps)(deps): bump actions/checkout from 5 to 6
dependabot[bot] 7aec39f
fix(security): upgrade Go to 1.25.5 to fix CVE-2025-61729
2e611e7
chore: sync develop with main after squash merge
3fb387a
fix(security): upgrade npm to 11.6.4 to fix CVE-2025-64756
a540fd9
fix(ci): optimize Super-Linter to reduce image size overhead
d65be88
fix(ci): replace Super-Linter with lightweight GitHub Actions
a6c2954
fix(ci): add Trivy scan resilience settings for large images
ced4ecb
refactor: remove experimental Go metrics exporter
6c3f3e5
chore: sync develop with main after glob patching fix
74c640f
feat: upgrade GitHub Actions runner to 2.330.0 (#1075)
GrammaTonic cb28e27
chore(deps): chore(deps)(deps): bump hadolint/hadolint-action from 3.β¦
dependabot[bot] 604dce1
fix: resolve disk space exhaustion in security scan workflow (#1077)
GrammaTonic 00f387c
chore(deps): chore(deps)(deps): bump actions/upload-artifact from 5 to 6
dependabot[bot] f0dcc4d
fix: replace broken free-disk-space action with manual cleanup (#1079)
Copilot 3e92e8e
chore: update runner version to 2.330.0 in docs and build scripts
GrammaTonic d4dee72
refactor: replace Go Prometheus implementation with netcat method
GrammaTonic 794cf1a
fix(security): patch CVE-2025-64756 glob vulnerability in standard ruβ¦
GrammaTonic 039aaec
Merge branch 'main' into develop
GrammaTonic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| # CVE-2025-64756 Fix: glob Command Injection Vulnerability | ||
|
|
||
| ## Overview | ||
|
|
||
| **Date**: December 18, 2025 | ||
| **CVE ID**: CVE-2025-64756 | ||
| **Severity**: HIGH | ||
| **Component**: `glob` package (transitive dependency) | ||
| **Location**: `actions-runner/externals/node24/lib/node_modules/npm/node_modules/node-gyp/node_modules/glob` | ||
|
|
||
| ## Vulnerability Details | ||
|
|
||
| The `glob` package versions < 10.5.0 and < 11.1.0 are vulnerable to command injection via malicious filenames. | ||
|
|
||
| - **Vulnerable Version**: 10.4.5 | ||
| - **Fixed Versions**: 10.5.0, 11.1.0, or higher | ||
| - **Applied Version**: 13.0.0 (latest stable) | ||
|
|
||
| ## Impact | ||
|
|
||
| The vulnerability allows attackers to execute arbitrary commands through specially crafted filenames when glob patterns are evaluated. This affects the GitHub Actions Runner's embedded Node.js distribution. | ||
|
|
||
| ## Resolution | ||
|
|
||
| ### Changes Made | ||
|
|
||
| Added `glob` package patching to all three Dockerfile variants: | ||
|
|
||
| 1. **Standard Runner** (`docker/Dockerfile`): | ||
| - Added `ARG GLOB_VERSION="13.0.0"` | ||
| - Updated embedded Node.js npm patching to include glob 13.0.0 | ||
| - Removes vulnerable glob 10.4.5 from node-gyp dependencies | ||
|
|
||
| 2. **Chrome Runner** (`docker/Dockerfile.chrome`): | ||
| - Already had glob patching implemented with version 13.0.0 | ||
| - No changes required | ||
|
|
||
| 3. **Chrome-Go Runner** (`docker/Dockerfile.chrome-go`): | ||
| - Already had glob patching implemented with version 13.0.0 | ||
| - No changes required | ||
|
|
||
| ### Technical Implementation | ||
|
|
||
| The patching process: | ||
|
|
||
| ```dockerfile | ||
| # Add glob version argument | ||
| ARG GLOB_VERSION="13.0.0" | ||
|
|
||
| # Patch embedded Node distributions | ||
| RUN --mount=type=cache,target=/tmp/npm-cache,uid=1001,gid=1001 \ | ||
| set -e; \ | ||
| for NODE_ROOT in /actions-runner/externals/node*/ ; do \ | ||
| if [ -x "${NODE_ROOT}bin/node" ] && [ -d "${NODE_ROOT}lib/node_modules/npm" ]; then \ | ||
| NPM_DIR="${NODE_ROOT}lib/node_modules/npm"; \ | ||
| PATCH_DIR="$(mktemp -d)"; \ | ||
| printf '{\n "name": "runner-patch",\n "private": true,\n "version": "1.0.0",\n "dependencies": {\n "cross-spawn": "%s",\n "tar": "%s",\n "brace-expansion": "%s",\n "glob": "%s"\n }\n}\n' \ | ||
| "${CROSS_SPAWN_VERSION}" "${TAR_VERSION}" "${BRACE_EXPANSION_VERSION}" "${GLOB_VERSION}" \ | ||
| > "${PATCH_DIR}/package.json"; \ | ||
| "${NODE_ROOT}bin/node" "${NPM_DIR}/bin/npm-cli.js" install \ | ||
| --prefix="${PATCH_DIR}" --omit=dev --cache /tmp/npm-cache; \ | ||
| rm -rf "${NPM_DIR}/node_modules/glob"; \ | ||
| cp -a "${PATCH_DIR}/node_modules/." "${NPM_DIR}/node_modules/"; \ | ||
| rm -rf "${PATCH_DIR}" "${NPM_DIR}/node_modules/.npm"; \ | ||
| fi; \ | ||
| done | ||
| ``` | ||
|
|
||
| ### Patching Strategy | ||
|
|
||
| 1. **Create temporary package.json** with safe dependency versions | ||
| 2. **Install patched versions** into temporary directory using BuildKit cache | ||
| 3. **Remove vulnerable versions** from runner's embedded Node.js | ||
| 4. **Copy patched versions** to replace vulnerable dependencies | ||
| 5. **Clean up** temporary files and npm cache | ||
|
|
||
| This approach: | ||
| - β Works across all Node.js versions in the runner | ||
| - β Doesn't modify runner binary (maintains GitHub signature) | ||
| - β Uses BuildKit cache for fast rebuilds | ||
| - β Runs during image build, not at runtime | ||
| - β No performance impact on runner startup | ||
|
|
||
| ## Verification | ||
|
|
||
| ### Manual Testing | ||
|
|
||
| After rebuilding images, verify the glob version: | ||
|
|
||
| ```bash | ||
| # For standard runner | ||
| docker run --rm github-runner:latest \ | ||
| bash -c 'node -e "console.log(require(\"/actions-runner/externals/node24/lib/node_modules/npm/node_modules/glob/package.json\").version)"' | ||
|
|
||
| # Expected output: 13.0.0 | ||
| ``` | ||
|
|
||
| ### CI/CD Validation | ||
|
|
||
| The fix will be validated by: | ||
| 1. Docker image build in CI/CD pipeline | ||
| 2. Security scanning with Trivy | ||
| 3. Runner self-test workflow | ||
| 4. GitHub code scanning rescan | ||
|
|
||
| ## References | ||
|
|
||
| - **CVE**: [CVE-2025-64756](https://avd.aquasec.com/nvd/cve-2025-64756) | ||
| - **GitHub Alert**: [#5660](https://github.com/GrammaTonic/github-runner/security/code-scanning/5660) | ||
| - **npm Package**: [glob@13.0.0](https://www.npmjs.com/package/glob) | ||
| - **Related Fixes**: | ||
| - CVE-2023-52576 (tar vulnerability) | ||
| - CVE-2024-27980 (cross-spawn vulnerability) | ||
| - CVE-2024-4068 (brace-expansion vulnerability) | ||
|
|
||
| ## Timeline | ||
|
|
||
| - **December 18, 2025**: CVE-2025-64756 reported in GitHub code scanning | ||
| - **December 18, 2025**: Fix implemented for all Dockerfile variants | ||
| - **Next**: CI/CD validation and image rebuild | ||
|
|
||
| ## Action Items | ||
|
|
||
| - [x] Add glob patching to standard Dockerfile | ||
| - [x] Verify Chrome and Chrome-Go Dockerfiles have glob patching | ||
| - [ ] Test Docker image builds | ||
| - [ ] Verify security alert resolution | ||
| - [ ] Deploy updated images to production | ||
|
|
||
| ## Notes | ||
|
|
||
| - The Chrome and Chrome-Go runners already had glob patching from a previous security update | ||
| - This fix brings the standard runner in line with the same security posture | ||
| - Using glob 13.0.0 (latest) provides maximum protection and future-proofs against similar vulnerabilities | ||
| - The vulnerability is in a transitive dependency, so direct updates to the runner package are not possible | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verification command provided is not sufficient to confirm the vulnerability is mitigated. It checks for the presence of the patched
globpackage at the top level ofnpm'snode_modules, but it doesn't verify that this is the versionnode-gyp(the source of the vulnerability) will actually resolve and use. A more reliable verification would executerequirefrom within thenode-gypdirectory to test Node.js's module resolution behavior directly.