Skip to content

Add auth service for signup, login, and token handling#166

Open
harsh-hak wants to merge 6 commits intoGopher-Industries:masterfrom
harsh-hak:add-auth-service-for-signup,-login,-and-token-handling
Open

Add auth service for signup, login, and token handling#166
harsh-hak wants to merge 6 commits intoGopher-Industries:masterfrom
harsh-hak:add-auth-service-for-signup,-login,-and-token-handling

Conversation

@harsh-hak
Copy link

Adds user authentication service supporting signup, login, and secure token handling. Refactors server to allow clean exports and easier testing.

@elanlaw1206
Copy link
Contributor

Hey Harsh ,

thanks for the update. I can’t approve this PR yet because it currently has a merge conflict in server.js (CORS section).

Fix suggestion: when resolving, please combine the two CORS approaches: keep the whitelist callback logic from master (so Postman/curl + localhost variants still work), but also include FRONTEND_ORIGIN as the primary allowed origin.

Also small improvement: can we avoid hardcoding FRONTEND_ORIGIN = "http://localhost:3000" and instead use process.env.FRONTEND_ORIGIN || "http://localhost:3000"?

Once the conflict is resolved and pushed (and CORS is consistent), tag me again , I’ll re-review and approve.

Thanks
King Hei

@elanlaw1206
Copy link
Contributor

Hi Harsh,

CI is currently failing because the workflow expects Vulnerability_Scanner_V1.4.py and the file is missing. I’d prefer to keep Vulnerability_Scanner_V1.4.py as it is currently referenced by the CI workflow, and removing it causes the checks to fail.

To avoid breaking the pipeline for this multi-trimester project, please restore/revert the deletion of Vulnerability_Scanner_V1.4.py. Once checks are green, I’m happy to approve.

Thanks
King Hei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants