Skip to content

fix: Ensure we use casefold column name in raw data type map#1684

Open
nj1973 wants to merge 8 commits intodevelopfrom
1683-sql-server-text-and-camelcase
Open

fix: Ensure we use casefold column name in raw data type map#1684
nj1973 wants to merge 8 commits intodevelopfrom
1683-sql-server-text-and-camelcase

Conversation

@nj1973
Copy link
Collaborator

@nj1973 nj1973 commented Feb 25, 2026

Description of changes

This PR fixes a bug where SQL Server CamelCase column names were bypassing raw data type checks.

I can't actually add the new test columns until after this PR is approved. I have manually tested but, after approval I'll add the columns and kick off a final test run before hitting merge.

I also documented a related SQL Server limitation.

Issues to be closed

Closes #1683

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973 nj1973 linked an issue Feb 25, 2026 that may be closed by this pull request
@nj1973
Copy link
Collaborator Author

nj1973 commented Feb 25, 2026

/gcbrun

@nj1973 nj1973 marked this pull request as draft February 25, 2026 17:22
@nj1973 nj1973 marked this pull request as ready for review February 25, 2026 17:30
@pull-request-size pull-request-size bot added size/S and removed size/M labels Feb 25, 2026
@nj1973
Copy link
Collaborator Author

nj1973 commented Feb 25, 2026

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Server text identification fails for CamelCase columns

1 participant