Conversation
b2ab099 to
629d26c
Compare
c0c9d64 to
8bed86c
Compare
| -DFLB_CONFIG_YAML=OFF \ | ||
| -DFLB_IN_SYSTEMD=On \ | ||
| -DFLB_MSGPACK_TO_JSON_INIT_BUFFER_SIZE=1.5 -DFLB_MSGPACK_TO_JSON_REALLOC_BUFFER_SIZE=.10 \ | ||
| -DFLB_CONFIG_YAML=OFF |
There was a problem hiding this comment.
Why did we need this? Was this removed from fluent bit?
There was a problem hiding this comment.
This change adds the flag -DFLB_PREFER_SYSTEM_LIB_ZSTD=On to the CMake command for RHEL 10. The modifications in this file do not affect other distributions.
Additionally, I have removed -DFLB_CONFIG_YAML=OFF because it is already included in the CMake command on line 31 (see screenshot).
Why is this change needed?
This change addresses the Fluent Bit core dump issue on RHEL 10 (see: Issue #11068). To resolve this, I have upgraded Fluent Bit to version 4.2.1 and also had to make the same changes as in this PR.
| sudo yum -y update | ||
|
|
||
| sudo yum -y install java-1.8.0-openjdk java-1.8.0-openjdk-devel cassandra | ||
| JAVA_VERSION=1.8.0 |
There was a problem hiding this comment.
Not sure what changed here? Why was this needed, I'm curious?
There was a problem hiding this comment.
AI...
reverted, thanks
| if [[ "$MAJOR_VERSION_ID" == "10" ]]; then | ||
| # For RHEL 10 (MySQL 8.4+), we use the default (caching_sha2_password) | ||
| echo "# Using default caching_sha2_password for RHEL 10" | sudo tee -a /etc/my.cnf |
There was a problem hiding this comment.
If this behaviour is tied to the mysql version then why not just check MYSQL_VERSION instead of the OS major version?
| sudo rpm --import https://repo.mysql.com/RPM-GPG-KEY-mysql-2022 | ||
| fi | ||
|
|
||
| MYSQL_VERSION="mysql80" |
There was a problem hiding this comment.
FYI -- support for 8.0 will be ending this April so we'll have an opportunity to simplify all of this soon and test 8.4 only. But also 9.0 is a thing now which we should consider adding soon too (not in this PR).
| # if os is rhel 9, crb is required to access epel | ||
| case "$VERSION_ID" in | ||
| 9*) sudo yum config-manager --set-enabled crb;; | ||
| 10*) sudo yum config-manager --set-enabled crb;; |
There was a problem hiding this comment.
Can 9 and 10 be combined? They're doing the same thing
Description
Fixed 3p tests, ops agent integration tests on Rhel10.
Ops agent integration tests and 3p tests no longer run against rhel8 during presubmit, they now run against rhel10.
Related issue
b/444772452
How has this been tested?
Checklist: