Skip to content

Conversation

@briandealwis
Copy link
Member

No description provided.

@briandealwis briandealwis requested a review from elharo June 7, 2017 15:21
`$ (cd eclipse; mvn package)`

1. Open the `Preferences` dialog, go to `Plug-in Development` > `Target Platform`.
1. Open the `ide-target-platform/gcp-ide-target-platform.target` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this path in the project explorer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have mentioned this: I renamed the eclipse/ide-target-platform project to just ide-target-platform. The Maven artifactID was previously ide-target-platform.repo and the .project had maven-dependencies. You may need to delete the maven-dependencies and/or ide-target-platform.repo projects and re-import them as existing projects.

@codecov-io
Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #2017 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2017   +/-   ##
=========================================
  Coverage     66.06%   66.06%           
  Complexity     1864     1864           
=========================================
  Files           322      322           
  Lines         12534    12534           
  Branches       1137     1137           
=========================================
  Hits           8281     8281           
  Misses         3828     3828           
  Partials        425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9359fca...d4a7864. Read the comment docs.

@briandealwis
Copy link
Member Author

Oh, this is why we don't use directory- or installation-based targets: https://bugs.eclipse.org/bugs/show_bug.cgi?id=501617

elharo
elharo previously approved these changes Jun 7, 2017
@briandealwis briandealwis dismissed elharo’s stale review June 8, 2017 20:55

Need to see if I can work around this JUnit issue.

@briandealwis
Copy link
Member Author

This is blocked on support for pulling the JUnit jars from unexploded bundles (Eclipse bug 501617). This has been fixed in Photon 4.8 M4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants