Skip to content

Added alias to react polyfills#17

Open
porfirioribeiro wants to merge 1 commit intoGoogleChromeLabs:masterfrom
porfirioribeiro:patch-1
Open

Added alias to react polyfills#17
porfirioribeiro wants to merge 1 commit intoGoogleChromeLabs:masterfrom
porfirioribeiro:patch-1

Conversation

@porfirioribeiro
Copy link

create-react-context and react-lifecycles-compat are polyfill's not needed if you use latest React version and they increase your bundle by 5kb!

create-react-context and react-lifecycles-compat are polyfill's not needed if you use latest React version and they increase your bundle by 5kb!
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@porfirioribeiro
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kurtextrem
Copy link
Contributor

kurtextrem commented Sep 20, 2018

That's a really clever trick.

Does UglifyJS remove the function call? If not, does /*#__PURE__*/ change it?

@porfirioribeiro
Copy link
Author

Hmm i haven't investigated at that level, but will try to see if it makes any difference using the pure comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants