Added alias to react polyfills#17
Open
porfirioribeiro wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Open
Added alias to react polyfills#17porfirioribeiro wants to merge 1 commit intoGoogleChromeLabs:masterfrom
porfirioribeiro wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Conversation
create-react-context and react-lifecycles-compat are polyfill's not needed if you use latest React version and they increase your bundle by 5kb!
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
Contributor
|
That's a really clever trick. Does UglifyJS remove the function call? If not, does |
Author
|
Hmm i haven't investigated at that level, but will try to see if it makes any difference using the pure comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-react-context and react-lifecycles-compat are polyfill's not needed if you use latest React version and they increase your bundle by 5kb!