You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. One thought about babel-react-optimize: should we avoid mentioning it? The primary use-case of this repo (as I see it) is:
a reader with a non-optimized app comes here,
they read over the libraries
and they apply plugins/tips from suitable sections to optimize the app.
babel-react-optimize doesn’t fit this use-case (the tip doesn’t help to make the app smaller); moreover, in fact, it advertises this solution (some readers might neglect the warning or skip it and install this preset)
2. Also: should we give an example of the transformation that the transform-react-pure-class-to-function plugin does? E.g., like we do for date-fns.
Hm, I see your point. However, I think people come here to learn about "how can I make my app faster/reduce bundle size?". So to say they are here to learn.
This is why I would teach them "not everything is good".
But I guess this one would be even better: Get a PR merged to babel-react-optimize to warn there, instead of on a 3rd party repo :)
Thinking about it again, and I think youʼre right, it makes sense for this repo!
Looking forward to merging this when we add transform-react-... examples :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9