Skip to content

Conversation

@duttarnab
Copy link
Contributor

@duttarnab duttarnab commented Dec 25, 2025

closes #2539

Summary by CodeRabbit

  • Chores
    • Updated asset resource permission scope mappings to align with standardized naming conventions for READ, WRITE, and DELETE operations.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

📝 Walkthrough

Walkthrough

A single LDIF template file is updated to rename three asset-related OAuth scope endpoints, replacing legacy jans_asset-* identifiers with standardized asset.* naming conventions. No functional behavior changes.

Changes

Cohort / File(s) Summary
Asset Scope Renaming
flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif
Updated three jansScope values: jans_asset-readasset.readonly, jans_asset-writeasset.write, jans_asset-deleteasset.admin

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

comp-flex-linux-setup, kind-feature

Suggested reviewers

  • devrimyatar
  • moabu

Poem

🐰 ✨ A scoping tale so neat and clean,
Old asset names swapped for new routines,
From jans_asset to asset.* they flow,
OAuth endpoints reborn, all aglow! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating renamed scopes in the adminUIResourceScopeMapping table, which matches the actual code changes in the pull request.
Linked Issues check ✅ Passed The code changes successfully update the scope names in adminUIResourceScopeMapping.ldif file, addressing the requirement from linked issue #2539 to reflect renamed scopes.
Out of Scope Changes check ✅ Passed The pull request contains only changes to scope mappings in the adminUIResourceScopeMapping.ldif file, which is directly aligned with the linked issue objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch flex-linux-setup-2539

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto mo-auto added comp-flex-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Dec 25, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87536ab and 29f565d.

📒 Files selected for processing (1)
  • flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-11T15:17:34.651Z
Learnt from: devrimyatar
Repo: GluuFederation/flex PR: 2440
File: flex-linux-setup/flex_linux_setup/flex_setup.py:519-519
Timestamp: 2025-11-11T15:17:34.651Z
Learning: In flex-linux-setup/flex_linux_setup/flex_setup.py, the webhook LDIF (aui_webhook.ldif) should only be imported during fresh Admin UI installations, not during updates. The import is correctly guarded by the check `client_check_result['2001.'] == -1` which ensures it only runs when the Admin UI Web Client doesn't already exist. Docker update workflows differ from Linux update workflows in this regard.

Applied to files:

  • flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif
🔇 Additional comments (1)
flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif (1)

94-94: Confirm the semantic intent of asset.admin versus the standard .delete suffix for DELETE operations.

The scope renaming is confirmed—old jans_asset-* references have been removed. However, line 113 uses asset.admin for DELETE access, which is inconsistent with the standard pattern used elsewhere in the file (e.g., clients.delete, scopes.delete, user.delete).

While ssa.admin also uses .admin for DELETE operations (lines 597, 607), suggesting this may be intentional, the semantic difference between .admin and .delete should be clarified. Does .admin grant broader permissions than .delete, or should this be aligned with the standard .delete suffix?

Verify that OAuth scope definitions in the authorization server configuration have been updated to include these new scope names.

@duttarnab duttarnab merged commit ece094b into main Dec 25, 2025
10 of 12 checks passed
@duttarnab duttarnab deleted the flex-linux-setup-2539 branch December 25, 2025 14:51
@duttarnab duttarnab requested a review from iromli December 25, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-flex-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(admin-ui): update the renamed scopes in adminUIResourceScopeMapping table

4 participants