-
Notifications
You must be signed in to change notification settings - Fork 19
feat(flex-linux-setup):update the renamed scopes in adminUIResourceScopeMapping table #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
📝 WalkthroughWalkthroughA single LDIF template file is updated to rename three asset-related OAuth scope endpoints, replacing legacy Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-11T15:17:34.651Z
Learnt from: devrimyatar
Repo: GluuFederation/flex PR: 2440
File: flex-linux-setup/flex_linux_setup/flex_setup.py:519-519
Timestamp: 2025-11-11T15:17:34.651Z
Learning: In flex-linux-setup/flex_linux_setup/flex_setup.py, the webhook LDIF (aui_webhook.ldif) should only be imported during fresh Admin UI installations, not during updates. The import is correctly guarded by the check `client_check_result['2001.'] == -1` which ensures it only runs when the Admin UI Web Client doesn't already exist. Docker update workflows differ from Linux update workflows in this regard.
Applied to files:
flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif
🔇 Additional comments (1)
flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif (1)
94-94: Confirm the semantic intent ofasset.adminversus the standard.deletesuffix for DELETE operations.The scope renaming is confirmed—old
jans_asset-*references have been removed. However, line 113 usesasset.adminfor DELETE access, which is inconsistent with the standard pattern used elsewhere in the file (e.g.,clients.delete,scopes.delete,user.delete).While
ssa.adminalso uses.adminfor DELETE operations (lines 597, 607), suggesting this may be intentional, the semantic difference between.adminand.deleteshould be clarified. Does.admingrant broader permissions than.delete, or should this be aligned with the standard.deletesuffix?Verify that OAuth scope definitions in the authorization server configuration have been updated to include these new scope names.



closes #2539
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.