Skip to content

Conversation

@faisalsiddique4400
Copy link
Contributor

feat(admin-ui): unused components cleanup and migration to single navigation wrapper (#2512)

Summary

Large-scale cleanup of unused components across the Admin UI and migration from scattered static navigations to a unified navigation wrapper.

Cleanup Overview

A total of 69+ unused components were identified and marked for removal through automated scanning combined with manual grep verification.

Components Targeted for Removal

Gluu Components (14)

  • GluuArrayCompleter.tsx
  • GluuAutoCompleteWithAdd.tsx
  • GluuBlockUI.tsx
  • GluuBooleanInput.tsx
  • GluuCheckBoxRow.tsx
  • GluuCustomScriptSearch.tsx
  • GluuEmptyRow.tsx
  • GluuFooter.tsx ✔ removed
  • GluuInput.tsx (GluuInputRow is still used)
  • GluuModal.tsx
  • GluuNameValueProperty.tsx
  • GluuNotification.tsx
  • GluuSingleValueCompleter.tsx ✔ removed
  • useExitPrompt.ts

Demo / Sample Components (36)
Charts, analytics, dashboards, tables, UI samples and placeholder components.

Internal Components (3)

  • RoutesRecursiveWrapper.tsx
  • UncontrolledTabsNavLink.tsx
  • Accordion/index.d.ts

Layout (1)

  • SidebarWithNavbarNavbar.tsx

Plugin Components (11)
Mostly unused legacy forms, LDAP/SQL config pages, bar chart implementations and unused hooks/schemas.

Core Components (2)

  • ExtendedDropdownLink.tsx
  • ExtendedDropdownSection.tsx

Dashboard Components (4)
CustomBadgeRow, CustomBarGraph, CustomLineChart, CustomPieGraph

Utilities (1)

  • storageUtils.ts (not referenced anywhere)

🧭 Navigation Migration

Goal
Move to a single unified Navigation wrapper instead of multiple static navigations.

Actions:

  • Introduced centralized navigation using useAppNavigation hook.
  • Replaced direct navigate() calls with navigateToRoute() utility.
  • Updated route references to use consistent ROUTES constants.
  • Removed redundant navigation logic and wrappers.

📊 Expected Improvements

Area Impact
Bundle Size Reduced significantly due to 69+ component removal
Maintainability Cleaner structure, faster onboarding
Performance Reduced JS bundle improves load/build time
Developer Experience One navigation pattern instead of many

⚡ Performance Check

Build time

  • Before: 40.19 seconds
  • After: 37.48 seconds
  • Improvement: ~2.7 seconds faster (~6.7% reduction)

Bundle size

  • Entrypoint: 7.42 MiB → 7.36 MiB (~60 KB smaller)
  • App modules: 170 → 145 modules (~90 KB smaller)
  • Plugin bundle: 344 KiB → 340 KiB (~4 KB smaller)

Impact

  • Faster builds: ~2.7 seconds saved per build
  • Smaller bundle: ~60 KB reduction in entrypoint
  • Fewer modules: 25 fewer modules to process
  • Better runtime performance: Less code to parse and execute

🔗 Ticket

Closes: #2512

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

38 files out of 145 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch admin-ui-issue-2512

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@faisalsiddique4400
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@faisalsiddique4400
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Base automatically changed from admin-ui-issue-2361-saml-1 to main December 11, 2025 10:50
faisalsiddique4400 and others added 2 commits December 11, 2025 16:05
Signed-off-by: Faisal Siddique <71010439+faisalsiddique4400@users.noreply.github.com>
Copy link
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In user claims on changing the status the Apply button is not activated.
  2. Unable to create entries in Website SSO / Identity Brokering ( SAML)

@sonarqubecloud
Copy link

@duttarnab duttarnab merged commit 4e35dd6 into main Dec 13, 2025
8 checks passed
@duttarnab duttarnab deleted the admin-ui-issue-2512 branch December 13, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(admin-ui): Unused Components Cleanup and migration to single Navigation wrapper from the individual static navigations.

3 participants