Added extra requirements#41
Open
hiyama341 wants to merge 1 commit intoGlobal-Biofoundries-Alliance:masterfrom
Open
Added extra requirements#41hiyama341 wants to merge 1 commit intoGlobal-Biofoundries-Alliance:masterfrom
hiyama341 wants to merge 1 commit intoGlobal-Biofoundries-Alliance:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I really like your package and I enjoy using it, but I would really like it to support python >3.8. As of now, the tesbml is hindering this, so I added this package as an additional requirement - since there is an ImportError in the file it is used which would be caught by the user.
If you think this is a good idea, I would also add documentation to this installation step. Roughly speaking this would include a few lines in the README file indicating that if the user wishes to use the sbmlgen module they have to install the additional packages as such: pip install synbiopython[all] or pip install synbiopython[tesbml]
Thanks for supporting the synbio community with this package. I will look forward to your reply.
Cheers,
Lucas