Glimpse gm lock fallback3 #8
Conversation
JasonMun7
added
documentation
JasonMun7
left a comment
JasonMun7
left a comment
There was a problem hiding this comment.
This looks great brandon! It will be much faster since you created the lock using View tags!
My one thing, however, to keep in mind is the responsiveness of other phone sizes but for now it should be fine! I'll talk a little more about developing with responsiveness at the next meeting!
There was a problem hiding this comment.
I think using an svg from the figma might make the code a little more readable and easier to make responsive, but overall the lock fallback component looks great!
There was a problem hiding this comment.
Got it, could you show me later how to use an svg from figma?
There was a problem hiding this comment.
Not sure if this is the best way to do so, but this is what I did for my components.
AndrewCheung360
left a comment
AndrewCheung360
left a comment
There was a problem hiding this comment.
Before merging, try to remove the .env file if possible from the branch and its commit history
JasonMun7
left a comment
JasonMun7
left a comment
There was a problem hiding this comment.
Yes as Andrew stated please remove the .env file and only push the changes for the lockFallback.tsx component. I'll go ahead and test it myself. I'm currently creating a testing environment and production environment via github.
|
also i thought i only pushed the lockfallback component but it looks like i pushed everything |
brandonysli
force-pushed
the
glimpse-GM-LockFallback3
branch
from
f60f942 to
8beeae6
Compare
created the lock fallback component