refactor/snitchmod-nullables-to-optional#53
Conversation
| store.get().close(); | ||
| store = Optional.empty(); | ||
| } | ||
| if (store == null && server != null) { |
There was a problem hiding this comment.
store == null -> store.isPresent()?
There was a problem hiding this comment.
Hey,
In the below line(119) I have done this, changed store == null to store.isPresent() and created a new SnitchesStore object and put that in optional, is there anything which I am missing here, please let me know.
Thanks
There was a problem hiding this comment.
Should it not be store.isEmpty()?
There was a problem hiding this comment.
you are correct, my bad, I have corrected it and pushed the code.
|
I just wanna let you know that while this looks good to me, I'd like to test it before approving. Unfortunately though I don't play much these days, hence the delay. |
no worries, thanks for the reply. |
|
@awoo-civ any update? |
3 participants
No description provided.