fix(bins): BINS BEGONE #186
Conversation
| ACTION_IF ~%WEIDU_OS%~ STR_EQ ~win32~ BEGIN | ||
| OUTER_SPRINT shell_cmd ~rmdir /s /q %MOD_FOLDER%\temp~ | ||
| END ELSE BEGIN //osx, unix | ||
| OUTER_SPRINT shell_cmd ~rm -rf %MOD_FOLDER%/temp~ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dark0dave
force-pushed
the
fix/includedbins
branch
from
081136c to
eec509b
Compare
EET/EET.tp2
Outdated
| PRINT ~%file% assigned to %tool%~ | ||
| END | ||
|
|
||
| ACTION_IF NOT ~%WEIDU_OS%~ STR_EQ ~win32~ BEGIN |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dark0dave
force-pushed
the
fix/includedbins
branch
from
eec509b to
473bc41
Compare
|
I've put back the rm -rf commands tho, I think its helpful to leave them in order for debug. yeah bin checking should happen up front at the start, so I don't scream in frustration after 5 minutes |
|
Also please understand that packing your own binaries for linux or macos is inherently bad and straight up dangerous. |
|
MacOS is inherently bad to begin with so I don't really see a difference on that front. |
Signed-off-by: dark0dave <dark0dave@mykolab.com>
dark0dave
force-pushed
the
fix/includedbins
branch
from
473bc41 to
46fba76
Compare
|
Please keep in mind that @K4thos merges PRs sporadically, so don't take it personal if you're perceived as ignored. |
|
Thats fine, I just wanted to fix this. |
|
@dark0dave Is there a reason why this PR removes shortcut creation support for Linux? |
|
EET_end seems to complete with warnings with this PR. I couldn't find anything helpful in the log, except for a short message about chmod failing to set the executable bit on a weidu binary. Possibly a regression from the binary removal? Suggestion: The readme should be updated with the information that on Linux and macOS platforms the weidu and lua binaries must be present on the system. I don't know if a specific Lua version is required. The binary originally shipped with EET was Lua 5.3, but some distros may still provide older versions by default. |
|
Sorry yes re shortcuts my bad. Will fix. |
|
I'll fix the chmod error. Likely trying to chmod exiting binaries. |
|
And I'll update the readme. |
3 participants
Signed-off-by: dark0dave dark0dave@mykolab.com