Add docker compose file for Ghostwriter-CLI #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColonelThirtyTwo
force-pushed
the
gh-cli-docker-compose-file
branch
2 times, most recently
from
e8a7401 to
7378eba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 368 368
Lines 20941 20941
=======================================
Hits 19148 19148
Misses 1793 1793 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ColonelThirtyTwo
force-pushed
the
gh-cli-docker-compose-file
branch
from
7378eba to
eb5745f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure for deploying Ghostwriter using pre-built container images from GHCR instead of building from source. It introduces a Docker Compose template (gw-cli.yml) that will be processed by Ghostwriter-CLI to generate deployment configurations, along with a GitHub Actions workflow to automatically publish versioned compose files on releases.
Changes:
- Added
gw-cli.ymlDocker Compose template with service definitions for django, postgres, nginx, redis, queue, graphql_engine, and collab-server using GHCR images - Added GitHub Actions workflow to substitute version placeholders and upload the compose file to releases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
gw-cli.yml |
Docker Compose template defining all Ghostwriter services with GHCR image references and placeholder version tags |
.github/workflows/gw-cli-compose-file.yml |
GitHub Actions workflow that replaces <VERSION> placeholders and uploads the compose file to releases |
Now that we are publishing docker images, add a docker compose file for Ghostwriter-CLI to download that uses those images. Add a workflow that replaces the version in the gw-cli.yml file with the current version and adds it as a release file, so that gw-cli can fetch it.
ColonelThirtyTwo
force-pushed
the
gh-cli-docker-compose-file
branch
from
eb5745f to
b550be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a docker compose file template and workflow for generating a docker compose file that uses the docker images published to the GHCR.
Ghostwriter-CLI will eventually download this file to set up Ghostwriter instances, rather than using a source code checkout, to avoid needing to build the containers and all of the inefficiencies and potential issues with doing so.
As with the two existing docker compose files included in the source tree, this compose file isn't intended to be used standalone, as it lacks the configuration env vars and will not perform the first time setup like installing fixtures.