Skip to content

Conversation

@mogita
Copy link

@mogita mogita commented Dec 16, 2025

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Copilot AI review requested due to automatic review settings December 16, 2025 07:08
@mogita mogita requested a review from tbarbugli as a code owner December 16, 2025 07:08
@mogita mogita had a problem deploying to feeds-enabled-shard December 16, 2025 07:08 — with GitHub Actions Failure
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR represents a comprehensive refactoring of the GetStream SDK, with code regenerated from refactored OpenAPI specifications. The changes primarily focus on improving type consistency, documentation, and API design across the feeds, chat, and video domains.

Key Changes

  • Type System Refactoring: Separation of request/response types with consistent naming patterns (e.g., *Request, *Response, *Payload suffixes)
  • Model Consolidation: Removal of duplicate or deprecated types (e.g., Channel, Message, User, Poll, Ban replaced with dedicated response types)
  • API Method Updates: Renamed batch operations methods (OwnCapabilitiesBatchOwnBatch) and added new delete operations
  • Enhanced Documentation: Added comprehensive comments to events, request types, and response types

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
requests.go Renamed request types with consistent *Request and *Payload suffixes; added new fields and types for batch operations
models.go Major refactoring: removed ~30 deprecated types, added ~50 new response types, enhanced event documentation, separated feeds/chat reaction types
feeds.go Minor change with an unprofessional comment that needs removal
feeds-v3.go Renamed OwnCapabilitiesBatch to OwnBatch, added DeleteFeedsBatch, updated DeleteFeedUserData endpoint from DELETE to POST
feeds_test.go Updated tests to match renamed methods and added new test for DeleteFeedsBatch
common_test.go Removed test skip statements for upload tests
chat_test.go Removed test skip statements for upload tests
chat.go Minor documentation update (duplicate event comment)
call.go Reformatted imports to use grouped style

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

//
// Sends events:
// - *
// - *
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicated comment "// - *" on line 920 should be removed. It appears to be a documentation error where the same wildcard event marker was added twice, which provides no additional information and reduces documentation clarity.

Suggested change
// - *

Copilot uses AI. Check for mistakes.
@mogita mogita had a problem deploying to feeds-enabled-shard December 16, 2025 07:36 — with GitHub Actions Failure
@mogita mogita had a problem deploying to feeds-enabled-shard December 16, 2025 07:44 — with GitHub Actions Failure
@mogita mogita deployed to feeds-enabled-shard December 16, 2025 08:30 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants