When piping imapcli output, an exception is raised if emails contain …#26
Open
codedump wants to merge 1 commit intoGentux:masterfrom
Open
When piping imapcli output, an exception is raised if emails contain …#26codedump wants to merge 1 commit intoGentux:masterfrom
codedump wants to merge 1 commit intoGentux:masterfrom
Conversation
…non-8-bit characters (e.g. utf-8 encoding). This does NOT happen during regular usage, only during pipe usage. The reason is that /dev/stdout, the device usually used for output, is essentially just an 8-bit character output device. This patch fixes this by explicitlyu converting everyting to utf-8 before it is being written to /dev/stdout.
Gentux
approved these changes
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will typically fail with imapcli:
It will throw an exception, something like this:
When piping imapcli output, an exception is raised if emails contain non-8-bit
characters. This usually does NOT happen during regular usage with a fairly
smart terminal, only during pipe usage. The reason is that stdout, the
device usually used for output, by default just expects non-encoded 8-bit
character data.
This patch fixes this by explicitly encoding everyting into utf-8 before it
is being written to stdout.
(See also this thread on SO: https://stackoverflow.com/questions/15740236/stdout-encoding-in-python )
Cheers