This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Use RWTexture2D.operator[] in favor of RWTexture2D.Load#4
Open
magcius wants to merge 1 commit intoGameTechDev:masterfrom
Open
Use RWTexture2D.operator[] in favor of RWTexture2D.Load#4magcius wants to merge 1 commit intoGameTechDev:masterfrom
magcius wants to merge 1 commit intoGameTechDev:masterfrom
Conversation
Load doesn't exist in a PSSL environment, but operator[] does.
Contributor
|
There seems to be differences in the .Load vs .operator[] approach - they produce different DXBC / ISA. Here's what it looks like: I don't have time to validate the changes right now unfortunately and I don't want to just change it and possibly break someone's code. Perhaps putting the operator[] under #ifdef-s might be easiest for now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load doesn't exist in a PSSL environment, but operator[] does.