Sync BitVM updates #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add verify_bigint_on_stack for bigint * change name and remove unreachable script
* zellic g1 fixes * test for read from stack * deleted hinted_x_from_eval_point and hinted_y_from_eval_point functions * fmt * used fq::is_zero instead of comparing bytes to zero * changed & to &&
* removed unnecessary log asserts * removed unnecessary if branch in tonelli shanks * removed unused imports
* fix fq6_hinted_mul_keep_elements * removed unused import * fmt
…put if NUM_PUBS > 1 (BitVM#369) * fixed num_pub>1 case * fixed num_pubs>1 case
* add empty stack check * fix comment
…itVM#371) * drop c left in the altstack * remove if branch in utils_fq12_square since it doesnt occur
…, and add note in tmul about a case about hint (BitVM#386)
* fix checksum length * add warning for repeated hashes * fix pushing digits * fmt * add hash length checks and comment verify_test_vector's temporarily since its not compatible with the new checksum length * fix secret key generation * remove BinarysearchVerifier bound check and add test to verify that it doesn't cause a vulnerability * fix raw_witness_to_signature digit conversion
* add validation for hint being a correctly formed T type value to tmul * check that hint y is valid in Fp254Impl::hinted_inv * add check_validity to places where hints are used * add Fq::check_validity and use it in necessary place * add hint validity checks to chunk::taps_points:ops::utils_point_add_eval * chore: rename check validity functions for cherry-picking optimized version * feat: add check_validity function to Fp254 * chore: incorperate cherry-picked version * opt: optimize copies for hint verifications with the cherry-picked verification * fmt --------- Co-authored-by: just-erray <c.e.aslan37@gmail.com>
* fix fp254impl issues * fmt * fmt * add back necessary conflicted functions
* clear part1 report * add assertion to push_u32_le * fmt * remove debug prints and improve test for limb_shr1_carry * fmt * limb_to_bits functions assert num_bits>0 * change G1Affine::roll, G2Affine::roll, G2Affine::copy parameters to in terms of Fq, and fix tests for bigint change * fmt * assert LIMB_SIZE < 31 in BigIntImpl * restore bigint/mul.rs because it is fixed in another pr * fmt * apply parameter change to double_prevent_overflow_keep_element too
* feat: add check_validity function to Fp254 * feat: add validity checks to some functions in taps_ext_miller.rs as samples * add validity check to taps_mul * feat: add is_valid function to Fp254 * fix-feat: fix validity checks for precompute_p and complete validity checks for taps_ext_miller.rs * feat: fix and add validity checks in taps_msm.rs * fix: a validity check in taps_points_ops.rs * fix-feat: correct and add validity checks * fix: correct tests for test_point_ops_and_multiply_line_evals_step_1 tests according to the changed form of the input * fix: add validity checks for G1Acc in chunk_msm * opt: remove unnecessary q4 validity check * fix: validity checks of taps_ext_miller::chunk_precompute_p_from_hash * feat: add functions to analyze max stack usage of chunks * fix: some typos and delete leftovers --------- Co-authored-by: Hakkush-07 <hakan.karakus@std.bogazici.edu.tr>
* create a version of G1Affine::hinted_check_add that the caller must use with points that are not t==q nor t==-q * optimize G1Affine::hinted_check_add and add TODO comments for later * rearrange wrong if checks in G1Affine::hinted_check_add * add validity checks to hints of new G1Affine::hinted_check_add * fix hint validity check and roll in G1Affine::hinted_check_add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.