Enable verbatimModuleSyntax in tsconfig#759
Merged
garrettjstevens merged 4 commits intomainfrom Feb 17, 2026
Merged
Conversation
This includes enabling the `@typescript-eslint/no-import-type-side-effects` rule and running the auto-fix to move all possible type imports to the top level, so that verbatimModuleSyntax can work as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verbatimModuleSyntaxis a new-ish and recommended tsconfig setting. It was left disabled during the changes made in #753 since it caused the bundling ofjbrowse-plugin-apolloto fail. This ended up being due toverbatimModuleSyntaxcausing TS to transpileimport { type Thing } from 'some-package'toimport {} from 'some-package', instead of removing the import altogether. This change enables lint rules that fiximport { type Thing } from 'some-package'toimport type { Thing } from 'some-package', which does get removed altogether, whenever possible. This allowsverbatimModuleSyntaxto be enabled. There are a lot of changed files, but they're basically all eslint auto-fixes.