1d elements dev #205

termi-official · 2021-10-08T02:44:10Z

I work coupled 1D-3D problems so for me it is sometimes helpful to visualize the solutions side by side while MFEM is computing the solution to track down issues.

The draft is not very clean yet and might come with some level of memory corruption (could not test everything in detail yet). This is basically my late try on fixing #68 .

To test the PR I currently just utilize two very simple meshes which I feed into MFEM example 0.

3D mesh

MFEM mesh v1.0

dimension
1

elements
5
1 1 0 1
1 1 1 2
1 1 2 3
1 1 2 4
2 1 4 5

boundary
3
1 0 0
2 0 3
3 0 5

vertices
6
3
  0    0 -1.0
1.0    0    0
2.0    0    0
3.0  1.0    0
3.0 -1.0    0
4.0 -1.0  1.0

3D vector test field

FiniteElementSpace
FiniteElementCollection: H1_1D_P2
VDim: 3
Ordering: 0

0
2.029082637937203
2.25675394962394
0
2.128376974811976
0
1.264541318968602
2.267918293780571
1.378376974811971
2.442565462217959
1.314188487405989
0.6947706594843015
2.179750465858888
1.880065462217956
2.412159705920951
1.783782731108984
1.709311978452903
2.293586121702257
0.7516884874059858
2.347971218514969
0.719594243702995
0
2.029082637937203
2.25675394962394
0
2.128376974811976
0
1.264541318968602
2.267918293780571
1.378376974811971
-1.442565462217959
1.314188487405989
0.6947706594843015
2.179750465858888
1.880065462217956
2.41211241205920951
1.783782731108984
1.709311978452903
-2.293586121702257
0.7516884874059858
0.347971218514969
0.719594243702995
0
2.029082637937203
2.25675394962394
0
2.128376974811976
0
1.264541318968602
2.267918293780571
1.378376974811971
2.442565462217959
-1.314188487405989
0.6947706594843015
-2.179750465858888
2.179750465858888
1.880065462217956
-2.412159705920951
1.783782731108984
2.293586121702257
-0.7516884874059858
2.347971218514969
0.719594243702995

2D mesh

MFEM mesh v1.0

dimension
1

elements
5
1 1 0 1
1 1 1 2
1 1 2 3
1 1 2 4
2 1 4 5

boundary
3
1 0 0
2 0 3
3 0 5

vertices
6
2
  0    0 
1.0    0 
2.0    0 
3.0  1.0 
3.0 -1.0 
4.0 -1.0

2d vector test field

FiniteElementSpace
FiniteElementCollection: H1_1D_P1
VDim: 2
Ordering: 0

-0.84018773
-0.39438292
-0.78309923
-0.79844004
-0.91164738
-0.19755137
-0.33522275
-0.7682296
-0.27777472
-0.55396998
-0.47739705
-0.6288709

scalar test field

0
2.029082637937203
2.25675394962394
0
2.128376974811976
0
1.264541318968602
2.267918293780571
1.378376974811971
2.442565462217959
1.314188487405989

GlVis output (left 2D, right 3D)

TODOs

Visualizing the grid without solution
Visualizing element attributes
~~Visualizing boundary attributes~~ (possible future work)
~~Visualizing the element endpoints correctly~~ (possible future work)
Visualizing high order solutions
Vector valued problems
Merge master after Configurable line width with modern OpenGL #232 gets merged
Add keys to control line width for solution interactively
Add tests

tzanio · 2021-10-16T23:46:18Z

This looks really cool @termi-official. If you clean it up we will be interested in merging it. -Tzanio

termi-official · 2021-10-23T14:26:23Z

Okay this is more problematic than anticipated. I am currently working on modifying the mesh to support mixed dimensional elements (while also making at least 1d branching meshes possible, because they are required from time to time in mechanics and electrophysiology).

One major issue I ran into is that the elements keep disconnecting (I assume because for branched meshes the connectivity tables are broken) - this is "fixed" by simply providing different visualization modes for now.

Some features are missing in 1d vis which I probably cannot address by myself. I am aware that the following does not work (see above for bullet points).

… quads.

termi-official · 2022-05-24T20:00:40Z

Turns out many of the issues I encountered has been fixed with recent MFEM patches and the ongoing restructuring of the GLVis codebase. Scalar field visualization is basically working now. Some minor things remain to be resolved for scalar fields.

However, vector-valued fields are still open, which are important in some areas of mechanics.

termi-official · 2022-05-24T22:31:58Z

Okay 3d vector visualization is also okayish now.

The visualization is not very pretty, because modifying the renderer to include dynamic line thickness information seems a big out of scope for now. I also noticed a crazy amount of code duplication between scalar and vector field visualizer classes. Maybe a good future PR is to merge the duplicate code (and hence features).

termi-official · 2023-08-04T14:07:31Z

Bump @tzanio @publixsubfan . I think #232 is not being worked on anymore? Can we merge this PR then and leave the open TODOs for a follow up PR which addresses line rendering?

tzanio · 2023-08-06T18:20:06Z

Can we merge this PR then and leave the open TODOs for a follow up PR which addresses line rendering?

Yes, lets do that. Sorry for the long delay @termi-official !

termi-official · 2023-08-06T20:52:10Z

Absolutely no problem! :) I will merge master and fi the remaining errors tomorrow.

tzanio

Two more items:

Can you please update CHANGELOG
Should we add some of the 1D example meshes/results in MFEM and/or https://github.com/GLVis/data?

Thanks again for the contribution, @termi-official!

Tzanio

tzanio · 2023-08-06T18:31:43Z

glvis.cpp

+   double      line_width    = GetLineWidth();
+   double      ms_line_width = GetLineWidthMS();


Do these make any difference?

If your question is regarding the change itself, then this change just introduces a call to the internal API to keep the defaults consistent. If your question is regarding whether multisampling makes a difference, then it depends on the system. Not all systems support the respective OpenGL calls for multisampling of lines, which is part of the reason why I wanted to merge the line rendering PR before this. However, this PR is also functional without the line rendering PR.

For example pressing A on my workstation during interactive visualization removes stair-casing though antialiasing.

tzanio · 2023-08-06T18:33:41Z

lib/vssolution.cpp

-         // if (vals(j) >= 0.0)
-         //    vals(j) = sqrt(vals(j));
-         // else
-         //    vals(j) = -sqrt(-vals(j));


Are we sure we can remove this?

It is a comment on master, so it does not have any functional consequences - should I leave it anyway?

termi-official · 2023-08-07T10:25:34Z

lib/vssolution.cpp

+         if (v_normals && dim > 1)
         {
            PrepareWithNormals();


Regarding this change here I am not super confident. This change will need intervention further intervention for the line rendering PR to setup the normals of the flat representation correctly.

termi-official · 2023-08-07T16:21:07Z

Sure, we can think about adding some of the 1D network mesh stuff to MFEM, but we might need to think a bit how to do this one properly. My heart simulation framework is heavy patchwork (subclasses of mesh to patch the connectivity tables) to work around the assumption that we have the scenario of more than 2 element sharing a face. I do not have a good solution to make this properly work for now, because this assumption seems to be quite deeply rooted into the MFEM core. Happy to discuss further.

Edit: I should note that the "solution" for the visualization in the PR description is hand-constructed and not part of any simulation. I can make a PR into the data repository for smoke tests.

tzanio · 2023-08-08T18:57:43Z

Thanks for making the changes, @termi-official !

termi-official added 3 commits October 8, 2021 03:45

3D works.

0dde1a3

Add first try on 1d elements in 2d.

e5b11f6

Fix some issues with 2D rendering.

ad5bc27

termi-official added 2 commits October 23, 2021 15:14

Fix crash in 2D.

493d5cb

Fix crash in 3D.

96a3a46

termi-official marked this pull request as ready for review October 23, 2021 14:26

tzanio added ready-for-review enhancement labels Oct 31, 2021

tzanio mentioned this pull request Apr 13, 2022

Final changes for glvis-4.2 #227

Merged

7 tasks

Merge v4.2 master.

1488a99

termi-official force-pushed the 1d-elements-dev branch from 5d20fa5 to 1488a99 Compare May 24, 2022 14:38

termi-official added 8 commits May 24, 2022 20:40

Make rendering of segments in 2D more like rendering of triangles and…

228c0e4

… quads.

Use same line width default everywhere.

335bed6

Fix typos.

57d4546

Improve nc rendering of segments in 3D.

e342339

Fixing crash in 3D for segment rendering.

c338a86

Fix astyle command being hardcoded.

e8096f9

Simplify segment rendering.

c5d9dee

Style+warnings.

883f2ac

termi-official added 4 commits May 24, 2022 23:43

Add support for vector-valued fields on segments.

e3f729b

Some cleanup.

34f1624

Style.

6ec3880

Remove obsolete variables.

9618441

Tweak grid visualization for 1d meshes embedded in 2d space.

adb037e

tzanio added in-review and removed ready-for-review labels Aug 6, 2023

make style

aca0fa7

tzanio approved these changes Aug 6, 2023

View reviewed changes

Merge branch 'master' into 1d-elements-dev

b17516b

termi-official commented Aug 7, 2023

View reviewed changes

Add changelog entry.

94350f7

Fix line renderer texture.

4383f05

jandrej self-requested a review August 12, 2023 17:14

jandrej approved these changes Aug 12, 2023

View reviewed changes

tzanio merged commit c2e621c into GLVis:master Aug 12, 2023

termi-official deleted the 1d-elements-dev branch August 12, 2023 21:29

		double line_width = GetLineWidth();
		double ms_line_width = GetLineWidthMS();

1d elements dev #205

1d elements dev #205

Uh oh!

Conversation

termi-official commented Oct 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODOs

Uh oh!

tzanio commented Oct 16, 2021

Uh oh!

termi-official commented Oct 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

termi-official commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

termi-official commented May 24, 2022

Uh oh!

termi-official commented Aug 4, 2023

Uh oh!

tzanio commented Aug 6, 2023

Uh oh!

termi-official commented Aug 6, 2023

Uh oh!

tzanio left a comment

Choose a reason for hiding this comment

Uh oh!

tzanio Aug 6, 2023

Choose a reason for hiding this comment

Uh oh!

termi-official Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

termi-official Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

tzanio Aug 6, 2023

Choose a reason for hiding this comment

Uh oh!

termi-official Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

termi-official Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

termi-official commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tzanio commented Aug 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

termi-official commented Oct 8, 2021 •

edited

Loading

termi-official commented Oct 23, 2021 •

edited

Loading

termi-official commented May 24, 2022 •

edited

Loading

termi-official commented Aug 7, 2023 •

edited

Loading