Selective averaging MPI4py implementation added.#470
Merged
josephdviviano merged 5 commits intomasterfrom Feb 16, 2026
Merged
Conversation
josephdviviano
approved these changes
Feb 16, 2026
Collaborator
josephdviviano
left a comment
There was a problem hiding this comment.
lgtm, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist:
-->
Description
This PR adds the selective averaging implementation originally written by Vasim @yuk12, with minor cleanup and refactoring.
To use the selective averaging implementation based on torch.distributed written by @younik, set
--spawn-backend dist(choices: ["dist", "mpi"]).Two MPI4PY-based selective averaging implementations are available. To select between them, use
--mpi-sa-mode(choices: ["general", "fast"]).Please let me know if there are any additional refactoring opportunities or improvements to consider.