Skip to content

Add abi_g16 and abi_g18#696

Open
mhan-mars wants to merge 1 commit intodevelopfrom
feature/abi_mh
Open

Add abi_g16 and abi_g18#696
mhan-mars wants to merge 1 commit intodevelopfrom
feature/abi_mh

Conversation

@mhan-mars
Copy link

@mhan-mars mhan-mars commented Feb 4, 2026

Description

Add ABI on GOES-16 and GOES-18.

@mhan-mars mhan-mars added enhancement New feature or request observations labels Feb 4, 2026
@Dooruk Dooruk requested review from gmao-wgu February 4, 2026 19:55
@mhan-mars mhan-mars requested a review from gmao-yzhu February 4, 2026 21:05
Copy link
Contributor

@gmao-yzhu gmao-yzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a question -- is the yaml file for g16 the same as g18 except for sat platform name?

@mhan-mars
Copy link
Author

The other difference between g16 and g18 is the the use_flag. g16 does not turn on channel 9, but g18 has.

@gmao-yzhu
Copy link
Contributor

gmao-yzhu commented Feb 5, 2026

This is a general comment about yaml files, not for this PR -- I really think our current way of specifying obs errors and cloud usage in satinfo and cloud*rc files as well as active tables are much easier to handle. I guess this question is for Doruk or SI team: Would it be possible to create a mechanism to populate such info into yaml files directly in the future?

@gmao-yzhu I agree w/ you ... I have thought about this a bit for a while. Indeed there is a somewhat similar issue related to how to hook convinfo.db into swell. I will file an issue on this and list what I can think of should be considered when it comes to this ... but you are completely correct that the mksi way is a much better way of handling this stuff.

@Dooruk
Copy link
Collaborator

Dooruk commented Feb 5, 2026

This is a general comment about yaml files, not for this PR -- I really think our current way of specifying obs errors and cloud usage in satinfo and cloud*rc files as well as active tables are much easier to handle. I guess this question is for Doruk or SI team: Would it be possible to create a mechanism to populate such info into yaml files directly in the future?

@gmao-yzhu, I'm not familiar with the current way, do you mean how it is handled in GSI? Maybe we can talk about this in the next Swell Development meeting or Wednesday JEDI ?

Are these observers in the R2D2 database?

On another note, adding these two observers will impact the atmos 3dvar results and OOPS outputs, which will in turn change the results. So we need someone to run and compare 3dvar_atmos with and without these observers, @rtodling or @gmao-wgu?

@gmao-yzhu
Copy link
Contributor

gmao-yzhu commented Feb 5, 2026

Doruk,

"@gmao-yzhu, I'm not familiar with the current way, do you mean how it is handled in GSI? " -- Yes. We can talk about that either at Swell or JEDI meeting.

Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine by me.

I just wonder about the default test case: do we have ioda ABI files for that?

@mhan-mars
Copy link
Author

I am not sure how active_channels are provided in SWELL.

@mhan-mars
Copy link
Author

These changes look fine by me.

I just wonder about the default test case: do we have ioda ABI files for that?

Yes, I have the ioda files for the ABI test.

@rtodling
Copy link
Contributor

rtodling commented Feb 5, 2026

Doruk,

"@gmao-yzhu, I'm not familiar with the current way, do you mean how it is handled in GSI? " -- Yes. We can talk about that either at Swell or JEDI meeting.

@gmao-yzhu Yanqiu, are you talking about the way satinfo is created in GEOS - with the satinfo database processing the columns of satinfo.txt?

@mhan-mars
Copy link
Author

I have the IODA files that I used to test JEDI for ABI. Where should I put the IODA files in SWELL?

@rtodling
Copy link
Contributor

rtodling commented Feb 5, 2026

I have the IODA files that I used to test JEDI for ABI. Where should I put the IODA files in SWELL?

You'll need to coordinate with @Dooruk and @mranst

@Dooruk
Copy link
Collaborator

Dooruk commented Feb 5, 2026

I have the IODA files that I used to test JEDI for ABI. Where should I put the IODA files in SWELL?

You'll need to coordinate with @Dooruk and @mranst

This is x0050 correct? @mhan-mars, what time frame do you have the files for? Do you have the _satbias files? Two time steps SWELL uses are within 2023-10-10

@ftgoktas, could you help @mhan-mars with registering the obs files please once we confirm all the necessary files are available?

@mhan-mars
Copy link
Author

I have the IODA files that I used to test JEDI for ABI. Where should I put the IODA files in SWELL?

You'll need to coordinate with @Dooruk and @mranst

This is x0050 correct? @mhan-mars, what time frame do you have the files for? Do you have the _satbias files? Two time steps SWELL uses are within 2023-10-10

@ftgoktas, could you help @mhan-mars with registering the obs files please once we confirm all the necessary files are available?

Yes, it is an experiment based on x0050. The ioda files from the ncdiag and satbias are located at /discover/nobackup/mhan/jedi_all/UFO4ObsGroup/Data

@ftgoktas
Copy link
Member

ftgoktas commented Feb 9, 2026

I have the IODA files that I used to test JEDI for ABI. Where should I put the IODA files in SWELL?

You'll need to coordinate with @Dooruk and @mranst

This is x0050 correct? @mhan-mars, what time frame do you have the files for? Do you have the _satbias files? Two time steps SWELL uses are within 2023-10-10

@ftgoktas, could you help @mhan-mars with registering the obs files please once we confirm all the necessary files are available?

@mhan-mars I checked /discover/nobackup/mhan/jedi_all/UFO4ObsGroup/Data and found ABI files for 2023-08-09. Do you have abi_g16 and abi_g18 obs files for 2023-10-10? Swell's default test suites use that date, and we can ingest them to R2D2 once we have the files.

@mhan-mars
Copy link
Author

I have the IODA files that I used to test JEDI for ABI. Where should I put the IODA files in SWELL?

You'll need to coordinate with @Dooruk and @mranst

This is x0050 correct? @mhan-mars, what time frame do you have the files for? Do you have the _satbias files? Two time steps SWELL uses are within 2023-10-10
@ftgoktas, could you help @mhan-mars with registering the obs files please once we confirm all the necessary files are available?

@mhan-mars I checked /discover/nobackup/mhan/jedi_all/UFO4ObsGroup/Data and found ABI files for 2023-08-09. Do you have abi_g16 and abi_g18 obs files for 2023-10-10? Swell's default test suites use that date, and we can ingest them to R2D2 once we have the files.

No, I don't have data for 2023-10-10. The experiment for ABI only covers until 23-9-6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request observations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants