Conversation
gmao-yzhu
left a comment
There was a problem hiding this comment.
I just have a question -- is the yaml file for g16 the same as g18 except for sat platform name?
|
The other difference between g16 and g18 is the the use_flag. g16 does not turn on channel 9, but g18 has. |
|
This is a general comment about yaml files, not for this PR -- I really think our current way of specifying obs errors and cloud usage in satinfo and cloud*rc files as well as active tables are much easier to handle. I guess this question is for Doruk or SI team: Would it be possible to create a mechanism to populate such info into yaml files directly in the future? @gmao-yzhu I agree w/ you ... I have thought about this a bit for a while. Indeed there is a somewhat similar issue related to how to hook convinfo.db into swell. I will file an issue on this and list what I can think of should be considered when it comes to this ... but you are completely correct that the mksi way is a much better way of handling this stuff. |
@gmao-yzhu, I'm not familiar with the current way, do you mean how it is handled in GSI? Maybe we can talk about this in the next Swell Development meeting or Wednesday JEDI ? Are these observers in the R2D2 database? On another note, adding these two observers will impact the atmos 3dvar results and OOPS outputs, which will in turn change the results. So we need someone to run and compare 3dvar_atmos with and without these observers, @rtodling or @gmao-wgu? |
|
Doruk, "@gmao-yzhu, I'm not familiar with the current way, do you mean how it is handled in GSI? " -- Yes. We can talk about that either at Swell or JEDI meeting. |
rtodling
left a comment
There was a problem hiding this comment.
These changes look fine by me.
I just wonder about the default test case: do we have ioda ABI files for that?
|
I am not sure how active_channels are provided in SWELL. |
Yes, I have the ioda files for the ABI test. |
@gmao-yzhu Yanqiu, are you talking about the way satinfo is created in GEOS - with the satinfo database processing the columns of satinfo.txt? |
|
I have the IODA files that I used to test JEDI for ABI. Where should I put the IODA files in SWELL? |
This is @ftgoktas, could you help @mhan-mars with registering the obs files please once we confirm all the necessary files are available? |
Yes, it is an experiment based on x0050. The ioda files from the ncdiag and satbias are located at /discover/nobackup/mhan/jedi_all/UFO4ObsGroup/Data |
@mhan-mars I checked |
No, I don't have data for 2023-10-10. The experiment for ABI only covers until 23-9-6. |
Description
Add ABI on GOES-16 and GOES-18.