Migrate requirements to pyproject.toml#686
Merged
Conversation
shiklomanov-an
previously approved these changes
Jan 27, 2026
Collaborator
shiklomanov-an
left a comment
There was a problem hiding this comment.
Looks good to me! Probably the sequence of PRs should be:
- This one
- Change CI-Workflows to use these build/install commands.
- Here -- remove
requirements.txt.
Collaborator
Author
Thanks, makes sense. The application tests should continue to run fine on develop with how it's done there, but if we switch to the new install commands it won't work for people's branches who haven't caught up yet, so I'm thinking I'll give it a little bit before changing it |
Dooruk
approved these changes
Jan 27, 2026
Collaborator
Dooruk
left a comment
There was a problem hiding this comment.
Looks good! uv pip install -e . improved my life already.
If we are looking into making some changes to CI-workflows, is it worth revisiting:
GEOS-ESM/CI-workflows#11?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the requirements to
pyproject.toml. Github requirements are specified in a separate section ofpyproject.toml. This will impact how users install swell, it basically just eliminates the need for separately installing requirements using the--requirementstag. Docs for all install methods have been updated. I've leftrequirements.txtpresent with a deprecation warning for the time being. This will give users a chance to move over to the new installation method without disruption before removing it completely.