Skip to content

Migrate requirements to pyproject.toml#686

Merged
mranst merged 10 commits intodevelopfrom
se/mranst/pyproject
Jan 28, 2026
Merged

Migrate requirements to pyproject.toml#686
mranst merged 10 commits intodevelopfrom
se/mranst/pyproject

Conversation

@mranst
Copy link
Collaborator

@mranst mranst commented Jan 26, 2026

This PR moves the requirements to pyproject.toml. Github requirements are specified in a separate section of pyproject.toml. This will impact how users install swell, it basically just eliminates the need for separately installing requirements using the --requirements tag. Docs for all install methods have been updated. I've left requirements.txt present with a deprecation warning for the time being. This will give users a chance to move over to the new installation method without disruption before removing it completely.

@mranst mranst requested a review from shiklomanov-an January 27, 2026 16:42
@mranst mranst marked this pull request as ready for review January 27, 2026 16:42
@mranst mranst requested a review from Dooruk as a code owner January 27, 2026 16:42
shiklomanov-an
shiklomanov-an previously approved these changes Jan 27, 2026
Copy link
Collaborator

@shiklomanov-an shiklomanov-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Probably the sequence of PRs should be:

  1. This one
  2. Change CI-Workflows to use these build/install commands.
  3. Here -- remove requirements.txt.

@mranst
Copy link
Collaborator Author

mranst commented Jan 27, 2026

Looks good to me! Probably the sequence of PRs should be:

1. This one

2. Change CI-Workflows to use these build/install commands.

3. Here -- remove `requirements.txt`.

Thanks, makes sense. The application tests should continue to run fine on develop with how it's done there, but if we switch to the new install commands it won't work for people's branches who haven't caught up yet, so I'm thinking I'll give it a little bit before changing it

Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! uv pip install -e . improved my life already.

If we are looking into making some changes to CI-workflows, is it worth revisiting:
GEOS-ESM/CI-workflows#11?

@mranst mranst merged commit 8ef3d9f into develop Jan 28, 2026
2 checks passed
@mranst mranst deleted the se/mranst/pyproject branch January 28, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments