Change SP to IP lib; updated GSIBEC accordingly#107
Merged
Conversation
rtodling
added
the
0 diff
Collaborator
|
It is not possible to make a comparison with a pinned version with these changes as it requires fv3-jedi and saber changes that went in since the pinned version. So @rtodling, I will assume you made the proper comparisons. |
Contributor
Author
|
I compared 3dvar - and it's zero-diff. |
Collaborator
Sounds good. FYI @mer-a-o & @jeromebarre in case you use this repo for building jedi. |
Dooruk
approved these changes
Feb 17, 2026
Collaborator
Dooruk
left a comment
Dooruk
left a comment
There was a problem hiding this comment.
I was able to build & ctests are passing. Ricardo confirmed 0 diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a zero-diff change that replaces the SP lib w/ IP; this the spectral transform library used by GSIBEC, thus the later changes accordingly.
Dependencies
This PR can only be taken once the following PR's have gone in:
Impact
None.