Skip to content

v2.6: Fix start-stop and missing GMI_HNO3 in NI AMIP ExtData yaml #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathomp4 merged 2 commits into from
Feb 17, 2026
Merged

v2.6: Fix start-stop and missing GMI_HNO3 in NI AMIP ExtData yaml #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6abac9e
v2.6: Fix missing GMI_HNO3 in NI AMIP ExtData yaml
mathomp4 Feb 13, 2026
dc38036
Fix start-stop issue
mathomp4 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

## [v2.6.1] - 2026-02-17

### Fixed

- Fix missing `GMI_HNO3` entry in `AMIP/NI2G_GridComp_ExtData.yaml` file
- Fix start-stop regression failure in SU GridComp

## [v2.6.0] - 2026-02-05

### Changed
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ endif()
if (GOCART_STANDALONE)
project (
GOCART
VERSION 2.6.0
VERSION 2.6.1
LANGUAGES Fortran CXX C) # Note - CXX is required for ESMF

if ("${PROJECT_SOURCE_DIR}" STREQUAL "${PROJECT_BINARY_DIR}")
Expand Down
7 changes: 5 additions & 2 deletions ESMF/GOCART2G_GridComp/NI2G_GridComp/AMIP/NI2G_GridComp_ExtData.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,8 @@ Exports:
collection: /dev/null
climNO3an3:
collection: /dev/null


GMI_HNO3:
collection: /dev/null
regrid: CONSERVE
sample: NI2G_sample_2
variable: GMI_HNO3
5 changes: 0 additions & 5 deletions ESMF/GOCART2G_GridComp/NI2G_GridComp/NI2G_GridCompMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,11 +860,6 @@ subroutine Run2 (GC, import, export, clock, RC)
thread = MAPL_get_current_thread()
workspace => self%workspaces(thread)

!if (workspace%first) then
!xhno3 = MAPL_UNDEF
!workspace%first = .false.
!end if

! Recycle HNO3 every 3 hours
if (alarm_is_ringing) then
xhno3 = NITRATE_HNO3
Expand Down
12 changes: 1 addition & 11 deletions ESMF/GOCART2G_GridComp/SU2G_GridComp/SU2G_GridCompMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ module SU2G_GridCompMod
real :: aviation_layers(4) ! heights of the LTO, CDS and CRS layers
real :: fSO4anth ! Fraction of anthropogenic emissions that are SO4
!logical :: firstRun = .true.
!real, pointer :: h2o2_init(:,:,:)

! PRC: logic for GMI coupling
logical :: using_GMI
Expand Down Expand Up @@ -533,8 +532,6 @@ subroutine Initialize (GC, IMPORT, EXPORT, CLOCK, RC)
LONS = LONS, &
LATS = LATS, __RC__ )

!allocate(self%h2o2_init(size(lats,1),size(lats,2),self%km), __STAT__)

! Is SU data driven?
! ------------------
call determine_data_driven (COMP_NAME, data_driven, __RC__)
Expand Down Expand Up @@ -1256,13 +1253,6 @@ subroutine Run2 (GC, import, export, clock, RC)

xoh = 0.0
xno3 = 0.0

if (workspace%firstRun) then
xh2o2 = MAPL_UNDEF
h2o2_init = MAPL_UNDEF
workspace%firstRun = .false.
end if

xh2o2 = h2o2_init

call SulfateUpdateOxidants (nymd, nhms, LONS, LATS, airdens, self%km, self%cdt, &
Expand Down Expand Up @@ -1332,7 +1322,7 @@ subroutine Run2 (GC, import, export, clock, RC)
call MAPL_VarSpecGet(InternalSpec(n), SHORT_NAME=short_name, __RC__)
call MAPL_GetPointer(internal, NAME=short_name, ptr=int_ptr, __RC__)
call WetRemovalUFS (self%km, self%klid, n, self%cdt, 'sulfate', &
KIN, MAPL_GRAV, self%radius(n), rainout_eff, self%washout_tuning, &
KIN, MAPL_GRAV, self%radius(n), rainout_eff, self%washout_tuning, &
self%wet_radius_thr, int_ptr, ple, t, airdens, pfl_lsan, pfi_lsan, SUWT, __RC__)
enddo

Expand Down