Open
Conversation
added 4 commits
September 17, 2021 08:03
The following modifications were made:
- CTM Env has the option to produce the courant numbers and mass fluxes needed for Advection.
- The flag output_forcingData needs to be set to true in CTM_GridComp.rc.
- The fields MFX, MFY, CX and CY should be included in HISTORY.rc
- CTM Env has the option to read the courant number and mass fluxes.
- The flag read_advCoreFields needs to be set to true in CTM_GridComp.rc
- CTM Convection was refactored.
- CTM Env has the option to do RAS calculations.
- The flag enable_rasCalculations needs to be set to true in CTM_GridComp.rc
- CTM has the option to do Advection or not.
- If choosing not to do Advection, the flag do_ctmAdvection needs to be set to false in CTM_GridComp.rc
- CTM Env was refactored to add an internal state and to include calculations to derive fields into
subroutines.
- CTM GridComp was edited to include an internal state.
- In CTM Env, the atmospheric pressure is now calculate using the surface pressure and AK and BK.
This is the most significant change among all the modifications.
…un in debugging mode.
…es that have one record only
mathomp4
reviewed
Dec 3, 2021
| USE MAPL | ||
| USE GmiConvectionMethod_mod ! GMI Convection component | ||
| USE GenericConvectionMethod_mod ! Generic Convection component | ||
| USE MAPL_Mod |
Member
There was a problem hiding this comment.
@JulesKouatchou Is there a reason you went back to MAPL_Mod? @tclune and the SI Team moved GEOS to use MAPL as the default in GEOS.
Member
There was a problem hiding this comment.
Note there are other moves to use MAPL_Mod in other files in this PR as well
Author
There was a problem hiding this comment.
- MAPL_Mod can be replaced by MAPL.
- The changes I do not produce zero-diff because the atmospheric pressure is now calculated instead of being read from file.
- Fully implmented the internal state in CTM_ConvectionGridCompMod.F90 - Removed GenericConvectionMethod_mod.F90 and GmiConvectionMethod_mod.F90 from CMakeLists.txt. The two files do not need to be compiled at this time. The file GenericConvectionMethod_mod.F90 might be completely removed. GmiConvectionMethod_mod.F90 needs to be kept and used if we decide to implement GMI specific calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the following changes in CTM Env to align the Icarus version of the code with the Jason one:
- The flag output_forcingData needs to be set to true in CTM_GridComp.rc.
- The fields MFX, MFY, CX and CY should be included in HISTORY.rc
- The flag read_advCoreFields needs to be set to true in CTM_GridComp.rc
The following tests were done to validate the changes: