Skip to content

v3: Set MEKE_POSITIVE to True#114

Merged
mathomp4 merged 3 commits intodevelopfrom
feature/v3-meke-positive
Feb 12, 2026
Merged

v3: Set MEKE_POSITIVE to True#114
mathomp4 merged 3 commits intodevelopfrom
feature/v3-meke-positive

Conversation

@mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Sep 10, 2025

Closes GEOS-ESM/MOM6#15

This PR sets MEKE_POSITIVE = True in the MOM_override files per request of @adarmenov

NOTE: I'm labeling as zero-diff as a C12 test showed it was. Not sure if in general it will be.

@mathomp4 mathomp4 requested a review from adarmenov September 10, 2025 16:08
@mathomp4 mathomp4 self-assigned this Sep 10, 2025
@mathomp4 mathomp4 requested a review from a team as a code owner September 10, 2025 16:08
@mathomp4 mathomp4 added the 0 diff dataocean Zero-diff for the dataocean model label Sep 10, 2025
adarmenov
adarmenov approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@adarmenov adarmenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathomp4 mathomp4 added the non 0-diff dataocean The changes in this pull request are non-zero-diff for amip label Sep 11, 2025
@mathomp4
Copy link
Member Author

mathomp4 commented Sep 11, 2025

@sinakhani @adarmenov I was slightly incorrect. It is mostly zero-diff. I forgot to compare the RESTART/MOM.res.nc files. Those are different in MEKE:

> cmpnc4 stock-v12-2025Sep10-1day-c12-MOM6/scratch/RESTART/MOM.res.nc mekepositive-v12-2025Sep10-1day-c12-MOM6/scratch/RESTART/MOM.res.nc
DIFFER : VARIABLE : MEKE : ATTRIBUTE : checksum : VALUES : "9C8202500CECA7AA" <> "82F8662FF9F4925E"
DIFFER : VARIABLE : MEKE : POSITION : [0,7,41] : VALUES : -1.39656e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,17,16] : VALUES : -2.85427e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,17,17] : VALUES : -1.3021e-10 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,17,19] : VALUES : -9.04985e-09 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,17,20] : VALUES : -3.72647e-09 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,17,21] : VALUES : -1.46024e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,17,22] : VALUES : -1.61508e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,18,13] : VALUES : -3.50014e-09 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,19,56] : VALUES : 4.33477e-10 <> 4.91376e-10
DIFFER : VARIABLE : MEKE : POSITION : [0,20,45] : VALUES : -9.83319e-09 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,20,46] : VALUES : -1.36173e-07 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,20,47] : VALUES : -2.15561e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,21,45] : VALUES : -2.83046e-07 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,21,46] : VALUES : -1.59942e-07 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,21,47] : VALUES : -2.34159e-07 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,21,48] : VALUES : -2.22435e-09 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,21,50] : VALUES : -1.41871e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,22,44] : VALUES : -7.12217e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,22,47] : VALUES : -7.69144e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,22,48] : VALUES : -5.37437e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,27,54] : VALUES : -6.82991e-08 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,28,56] : VALUES : -1.01624e-09 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,32,65] : VALUES : 9.48009e-10 <> 9.50239e-10
DIFFER : VARIABLE : MEKE : POSITION : [0,33,9] : VALUES : -1.0196e-09 <> 0
DIFFER : VARIABLE : MEKE : POSITION : [0,34,52] : VALUES : -3.88519e-07 <> 0

I guess MEKE doesn't feed back to the atmosphere in anyway? Because all the GEOS checkpoints were zero-diff.

@mathomp4 mathomp4 added non 0-diff coupled Non-zero-diff for coupled model non 0-diff dataatm Non-zero-diff for dataatm and removed non 0-diff dataocean The changes in this pull request are non-zero-diff for amip labels Sep 15, 2025
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@mathomp4 mathomp4 merged commit d369de8 into develop Feb 12, 2026
5 of 7 checks passed
@mathomp4 mathomp4 deleted the feature/v3-meke-positive branch February 12, 2026 13:41
@mathomp4 mathomp4 mentioned this pull request Feb 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinakhani sinakhani sinakhani approved these changes

@adarmenov adarmenov adarmenov approved these changes

Assignees

@mathomp4 mathomp4

Labels

0 diff dataocean Zero-diff for the dataocean model non 0-diff coupled Non-zero-diff for coupled model non 0-diff dataatm Non-zero-diff for dataatm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Floating invalid error in the calculation of lateral diffusion

3 participants

@mathomp4 @sinakhani @adarmenov

Comments