Conversation
| endif | ||
|
|
||
| if (ak_is_missing .or. bk_is_missing) call set_eta(km, ls, ptop, pint, AK, BK) | ||
| if (ak_is_missing .or. bk_is_missing) then |
There was a problem hiding this comment.
This duplicates logic above. It should be moved into an internal procedure and then just called from the two locations.
There was a problem hiding this comment.
The interfaces are different. I am not sure how to avoid the logic. Since it is already moved to init(), it is not a big issue.
| allocate ( r8_ak(npz+1) ) | ||
| allocate ( r8_bk(npz+1) ) | ||
| call set_eta(npz,ks,ptop,pint,r8_ak,r8_bk) | ||
| if (trim(eta_rc_file) == 'None') then |
There was a problem hiding this comment.
and duplicated again here ...
tclune
left a comment
tclune
left a comment
There was a problem hiding this comment.
Mostly little things, but the read during the run method bothers me.
tclune
left a comment
tclune
left a comment
There was a problem hiding this comment.
Sorry - missed that there were two grid comps that needed the change.
Still might be worth refactoring to a shared procedure, but ... harder now.
tclune
left a comment
tclune
left a comment
There was a problem hiding this comment.
Very nice.
If there were any changes, I might ask that you modify the name of the internal state. Conventionally these are named after the component itself, though I think your name is much clearer. So please leave it as is, but be prepared to switch it if anyone asks.
2 participants
This merge requires the merge of GMAO_Shared branch feature/wjiang/#149-add_write_eta which provide the module shared_topo_remap