Skip to content

Conversation

@petr-kus
Copy link

@petr-kus petr-kus commented Dec 1, 2025

I added the ability to read the help text using the keyword Get Property From Element.
Previously, there was no way to check an element’s help text at all. (except path search)
I have validated and tested the functionality in my local environment.

@alainsiroishw
Copy link
Contributor

@petr-kus
Copy link
Author

petr-kus commented Dec 2, 2025

Hello

My last pull request became valid after I fixed similar errors:

https://ci.appveyor.com/project/GDATACyberDefenseAG/robotframework-flaui/builds/53165754/job/8tyq0dbeoneu1cvu#L738 https://ci.appveyor.com/project/GDATACyberDefenseAG/robotframework-flaui/builds/53165754/job/8tyq0dbeoneu1cvu#L739

Hmm, thank you for the direction. However, I can't find any issues with the tests. What exactly do you mean? According to the message, there is only one check failing—does someone need to review it?

Or should I automatically increase the version? I’m thinking that might be the reason the build is failing. Is that what you mean?

@Nepitwin
Copy link
Member

Nepitwin commented Dec 2, 2025

Actuall implementation pylint said

************* Module src.FlaUILibrary.flaui.module.property
src\FlaUILibrary\flaui\module\property.py:351:0: C0303: Trailing whitespace (trailing-whitespace)
src\FlaUILibrary\flaui\module\property.py:360:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise FlaUiError(FlaUiError.PropertyNotSupported) from exc' (raise-missing-from)

Has to be fixxed asweel

@Nepitwin
Copy link
Member

Nepitwin commented Dec 2, 2025

Pls adjust under CHANGELOG.md new keyword as upcoming change.

@alainsiroishw
Copy link
Contributor

alainsiroishw commented Dec 2, 2025

Hello
My last pull request became valid after I fixed similar errors:
https://ci.appveyor.com/project/GDATACyberDefenseAG/robotframework-flaui/builds/53165754/job/8tyq0dbeoneu1cvu#L738 https://ci.appveyor.com/project/GDATACyberDefenseAG/robotframework-flaui/builds/53165754/job/8tyq0dbeoneu1cvu#L739

Hmm, thank you for the direction. However, I can't find any issues with the tests. What exactly do you mean? According to the message, there is only one check failing—does someone need to review it?

Or should I automatically increase the version? I’m thinking that might be the reason the build is failing. Is that what you mean?

Hello @petr-kus . The links had line numbers at the end. You had to look at the top of the page after clicking them. Nepitwin already did a copy paste in later messages in the PR.

Also, please look at this: https://github.com/GDATASoftwareAG/robotframework-flaui?tab=readme-ov-file#releasing-a-new-version---frequent-tasks

@Nepitwin
Copy link
Member

Hello
My last pull request became valid after I fixed similar errors:
https://ci.appveyor.com/project/GDATACyberDefenseAG/robotframework-flaui/builds/53165754/job/8tyq0dbeoneu1cvu#L738 https://ci.appveyor.com/project/GDATACyberDefenseAG/robotframework-flaui/builds/53165754/job/8tyq0dbeoneu1cvu#L739

Hmm, thank you for the direction. However, I can't find any issues with the tests. What exactly do you mean? According to the message, there is only one check failing—does someone need to review it?

Or should I automatically increase the version? I’m thinking that might be the reason the build is failing. Is that what you mean?

Test are not the issue here it's pylint

************* Module src.FlaUILibrary.flaui.module.property
src\FlaUILibrary\flaui\module\property.py:351:0: C0303: Trailing whitespace (trailing-whitespace)
src\FlaUILibrary\flaui\module\property.py:360:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise FlaUiError(FlaUiError.PropertyNotSupported) from exc' (raise-missing-from)

In module.property you have to fix the trailing whitespaces and the exception which is called to raise correctly.

You can verify pylint locally on your machine with

keen.bat pylint

@Nepitwin
Copy link
Member

@petr-kus

  • I rebased your branch on latest main changes from me.

  • I fixxed your pylint issues.

  • Pls adjust CHANGELOG.md with new keyword in Unreleased part with ### Added section

  • Pls write a atests which helptext will be tested

Then all looks fine

Version.py has not to be adjusted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants