add folding based on fold expression#17
add folding based on fold expression#17cnrrobertson wants to merge 3 commits intoGCBallesteros:mainfrom
Conversation
should only apply to filetypes with a valid cell marker in the config
lua/notebook-navigator/init.lua
Outdated
| if M.config.cell_markers[ft] then | ||
| local marker = M.config.cell_markers[ft] | ||
| local vim_marker = string.gsub(marker, " ", "\\ ") | ||
| local expr = "set foldexpr=(getline(v:lnum)=~'^"..vim_marker.."')==0" |
There was a problem hiding this comment.
This is going to overwrite whatever code folding a user has set. If you are only on folding cells that is fine but for example one thing that I do quite often after opening a file is zC to close all the folds to get a higher level view.
I would imagine that one approach to fix solve this is to wrap around the folding method currently in use so that it returns the fold level on top of the one that was set before.
Another issue is that this will changed the global fold method. Ideally one would rather use setlocal to only change it on the window displaying the buffer of interest.
There was a problem hiding this comment.
Really good point about setlocal. I've implemented that change.
On wrapping the current folding method. I think it could be done if the folding was set to fold-indent, fold-expr, or fold-marker but I'm not sure how to get an expr wrapping fold-syntax or fold-diff. Any ideas?
In any case, I've also added a warning for the time being that the code folding will replace previously defined foldmethods on buffers with valid cell markers.
There was a problem hiding this comment.
I would be happy with just having the cell folding working for a limited number of user set folding methods. Indent, expr and marker would be enough as they cover most of the situations.
Currently I'm wokring on wrapping around the output of the current foldexpr such that it produces the correct folding when cells are considered too. I will upload a branch later today or tomorrow morning sketching the idea.
2 participants
should only apply to filetypes with a valid cell marker in the config. Addresses #9 with a more elegant approach.