V5.21 #30
Merged
V5.21 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR (V5.21) resolves issue #21 by updating type definitions, removing the EMAIL property, updating news content metadata, and introducing a new promotion collection configuration.
- Removed the EMAIL field from the Site type and SITE constant
- Updated news post metadata (date and draft flags) in both English and German content
- Added a new promotion collection in the content configuration
Reviewed Changes
Copilot reviewed 8 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Removed the EMAIL property from the Site type |
| src/content/news/en/what-you-can-learn-from-futureblurs-philosophy.md | Updated date and draft flag |
| src/content/news/de/what-you-can-learn-from-futureblurs-philosophy.md | Updated date, draft flag, and added a period in a caption |
| src/content/config.ts | Added the promotion collection with new validation |
| src/consts.ts | Removed the EMAIL property from the SITE object |
Files not reviewed (15)
- package.json: Language not supported
- src/components/Footer.astro: Language not supported
- src/components/Header.astro: Language not supported
- src/components/Home/Promotion.astro: Language not supported
- src/components/Icons/FutureblurLogo.astro: Language not supported
- src/components/LocaleHeader.astro: Language not supported
- src/components/Navigation/NavBar.astro: Language not supported
- src/components/Navigation/NavBarLinks.astro: Language not supported
- src/content/promotion/de/archviz.json: Language not supported
- src/content/promotion/de/octane.json: Language not supported
- src/content/promotion/en/archviz.json: Language not supported
- src/content/promotion/en/octane.json: Language not supported
- src/layouts/Layout.astro: Language not supported
- src/pages/[lang]/index.astro: Language not supported
- src/styles/global.css: Language not supported
Comments suppressed due to low confidence (1)
src/content/config.ts:10
- The error message for the 'order' field may be misleading because the 'nonnegative' validation accepts zero as valid. Consider updating the message to indicate that a value of zero is acceptable, or adjust the validation if only strictly positive numbers are allowed.
order: z.number().nonnegative({ message: 'Promotion object order needs to be positive.' }),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21.