Skip to content

Revert "Creating unified save functions, always save to keep in sync" #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connortobrien wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "Creating unified save functions, always save to keep in sync" #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions init-activities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,6 @@ function setCookie(name, value, days) {
document.cookie = name + '=' + (value || '') + expires + '; path=/';
}

function getJSONFromMemory(name) {
const value = getJSONFromCookie(name);
if (value !== null) return value;
return getJSONFromStorage(name);
}

function setJSONToMemory(name, data) {
setJSONCookie(name, data);
setJSONStorage(name, data);
}

function getJSONFromCookie(cookieName) {
const cookies = document.cookie.split(';');

Expand Down Expand Up @@ -146,7 +135,7 @@ function setJSONStorage(key, data) {
}

function cleanupStoredVariations() {
const storageValue = getJSONFromMemory(COOKIE_NAME);
const storageValue = getJSONFromStorage(COOKIE_NAME);
if (!storageValue || !storageValue.variations) return;

const storedVariations = storageValue.variations;
Expand All @@ -173,7 +162,9 @@ function cleanupStoredVariations() {
});

// Update storage with cleaned variations
setJSONToMemory(COOKIE_NAME, { ...storageValue, variations: cleanedVariations });
if (Object.keys(cleanedVariations).length !== Object.keys(storedVariations).length) {
setJSONStorage(COOKIE_NAME, { ...storageValue, variations: cleanedVariations });
}
}

function detectAudiences(userAudience, activityAudiences) {
Expand Down Expand Up @@ -510,7 +501,7 @@ function attachJsFile(src) {
function loadVariation(activity) {
const activityName = activity.activity;
const variations = activity.variants;
const storageValue = getJSONFromMemory(COOKIE_NAME) || { variations: {} };
const storageValue = getJSONFromStorage(COOKIE_NAME) || { variations: {} };
const storageVariations = storageValue.variations || {};

// --- Helper: Weighted random selection ---
Expand Down Expand Up @@ -597,7 +588,7 @@ function loadVariation(activity) {
if (overrideVariant && variations?.[overrideVariant]) {
// set storage to value used in override
storageVariations[activityName] = overrideVariant;
setJSONToMemory(COOKIE_NAME, { ...storageValue, variations: storageVariations });
setJSONStorage(COOKIE_NAME, { ...storageValue, variations: storageVariations });
setClarityTags(activityName, overrideVariant);
setTrackMetricsLink(activityName, overrideVariant);
// Load overridden variant without modifying storage
Expand All @@ -611,7 +602,7 @@ function loadVariation(activity) {
if (!selectedVariation || !variations?.[selectedVariation]) {
selectedVariation = selectVariation(variations);
storageVariations[activityName] = selectedVariation;
setJSONToMemory(COOKIE_NAME, { ...storageValue, variations: storageVariations });
setJSONStorage(COOKIE_NAME, { ...storageValue, variations: storageVariations });
}

setClarityTags(activityName, selectedVariation);
Expand Down