This repository was archived by the owner on May 12, 2024. It is now read-only.
Support xdotool as well as ydotool#1
Open
forbesmyester wants to merge 6 commits intoFunctionalHacker:masterfrom
Open
Support xdotool as well as ydotool#1forbesmyester wants to merge 6 commits intoFunctionalHacker:masterfrom
forbesmyester wants to merge 6 commits intoFunctionalHacker:masterfrom
Conversation
Owner
|
Thanks a lot! I will try to go through your code during this week, test it, merge and tag a new release. I assume xdotool compability is for when we get this to run WM agnostic? Because right now this is Sway only. |
fzf-pass
Outdated
|
|
||
| function ldotool { | ||
| ydotool type "" | ||
| if [ $? eq 0 ]; then |
Owner
There was a problem hiding this comment.
I get this error on my machine:
./fzf-pass: line 6: [: eq: binary operator expected
fzf-pass
Outdated
| if [ $? eq 0 ]; then | ||
| ydotool "$@" | ||
| else | ||
| xdotool "$@" |
Owner
There was a problem hiding this comment.
I don't have xdotool installed on my machine so I get this:
./fzf-pass: line 9: xdotool: command not found
This is probably related to the error on line 6, see my comment there.
FunctionalHacker
suggested changes
Apr 25, 2020
Owner
FunctionalHacker
left a comment
FunctionalHacker
left a comment
There was a problem hiding this comment.
Check my comments on line 6 and 9. This looks like a simple syntax error so should be an easy fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.