Skip to content

Conversation

@dearden
Copy link
Contributor

@dearden dearden commented Dec 23, 2025

Fixes AI-1683.

Reintroduces thresholds for all sentence linking functions.

This will allow us to use a different threshold in Prebunking at Scale.

Also adds a new test to check thresholds are working.


Pull request checklist

  • I have linked my PR to an issue
  • I’ve used conventional commits
  • My branch is up-to-date with main
  • Where appropriate, I have added or updated tests
  • Where appropriate, I have updated documentation to reflect my changes

@dearden dearden requested a review from dcorney December 23, 2025 14:22
@github-actions
Copy link

❗ The branch name reintroduce-threshold-parameter-1683 does not follow the pattern [issue-number]-description-here.

In order to correctly link this PR to an issue, the branch name should be prefixed with the relevant issue number.

Please recreate this PR using required branch name structure (e.g. 42-reintroduce-threshold-parameter-1683).

Copy link

@dcorney dcorney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dcorney
Copy link

dcorney commented Dec 23, 2025

When we do a new release for this, please check the version number - I think it should be "v5.0.1" or similar.

Copy link

@dcorney dcorney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dearden dearden merged commit 5a4dfb0 into main Jan 5, 2026
4 checks passed
@dearden dearden deleted the reintroduce-threshold-parameter-1683 branch January 5, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants